test(utils): Enhance unit test coverage for getViewerLocalHour with invalid date strings - #9031
Conversation
|
@Rakshak05 is attempting to deploy a commit to the jhasourav07's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
This PR adds significant unit test coverage for the |
📦 Next.js Bundle Size Report (Gzipped Sizes)✨ No significant bundle size changes detected. 📊 Summary of Totals
|
Aamod007
left a comment
There was a problem hiding this comment.
Solid set of edge case tests! The extra type guard on \isoDate\ is a great small addition for runtime safety. Approved!
|
🎉 Congratulations @Rakshak05! Your PR has been successfully merged. 🚀 Thank you for contributing to CommitPulse. Your work helps us build a better tool for the community.
Keep building! 💻✨ |
Description
Fixes #8633
This PR adds comprehensive unit test coverage for the
getViewerLocalHourutility function inutils/dateHelpers.ts.Changes Included:
+02:00,-05:00,Z).2024-03-10,2024-03).'').invalid-date,2024-03-XX,hello world).2024-03-10T,2024-13-99T25:99:00).-9999999-01-01).999999999-01-01).null,undefined).getViewerLocalHour(typeof isoDate !== 'string') for added runtime safety.0to23).Pillar
Visual Preview
N/A (Unit test coverage expansion)
Checklist before requesting a review:
CONTRIBUTING.mdfile.localhost:3000/api/streak?user=YOUR_USERNAME).npm run formatandnpm run lintlocally and resolved all errors (CI will fail otherwise).feat(themes): ...,fix(calculate): ...).README.mdif I added a new theme or URL parameter.