Skip to content

Skipped tests to be shown as skipped in vstest (former showing as suc… #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
abhilashsur wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Skipped tests to be shown as skipped in vstest (former showing as suc… #76

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a3d721a
Skipped tests to be shown as skipped in vstest (former showing as suc…
Oct 10, 2024
ee15f1c
Corrected review comments
Feb 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions Libraries/Catch2Interface/Reporter/OverallResult.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ public class OverallResult
public string StdErr { get; private set; } = string.Empty;
public string StdOut { get; private set; } = string.Empty;
public bool Success { get; private set; } = false;
public bool Skipped { get; private set; } = false;

@rbeesley rbeesley Nov 26, 2024

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alignment nit.


#endregion // Properties

Expand All @@ -53,6 +54,12 @@ public OverallResult(XmlNode node)
Success = Constants.Rgx_True.IsMatch(success);
}

var skipped = node.Attributes["skips"]?.Value;
if (skipped != null && skipped == "1")
{
Skipped = true;
}

double duration = 0.0;
if (double.TryParse(node.Attributes["durationInSeconds"]?.Value, _style, _culture, out duration))
{
Expand Down
8 changes: 8 additions & 0 deletions Libraries/Catch2Interface/TestResult.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,10 @@ public TestResult(Reporter.TestCase testcase, Settings settings, bool combined)
Duration = _testcase.OverallResult.Duration;
Name = _testcase.Name;
Outcome = _testcase.OverallResult.Success ? TestOutcomes.Passed : TestOutcomes.Failed;
if(testcase.OverallResult.Skipped)

@rbeesley rbeesley Nov 26, 2024

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Likely should be if (_testcase.OverallResult.Skipped). Missing the underscore.

{
Outcome = TestOutcomes.Skipped;
}
StandardOut = _testcase.OverallResult.StdOut;
StandardError = _testcase.OverallResult.StdErr;

Expand Down Expand Up @@ -420,6 +424,10 @@ void ExtractTestResult(XmlNode nodeGroup)
_testcase = testcase;

Outcome = _testcase.OverallResult.Success ? TestOutcomes.Passed : TestOutcomes.Failed;
if(_testcase.OverallResult.Skipped)
{
Outcome = TestOutcomes.Skipped;
}
Duration = _testcase.OverallResult.Duration;
StandardOut = _testcase.OverallResult.StdOut;
StandardError = _testcase.OverallResult.StdErr;
Expand Down