Repository navigation
Conversation
Run AirspeedVelocity benchmarks on pull_request instead of pull_request_target so untrusted PR code does not execute with privileged base-repository permissions. Write benchmark output to the job summary instead of PR comments, which lets the workflow token remain read-only.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pull_requestinstead ofpull_request_targetcontents: readjob-summary: trueinstead of posting PR comments[master, main]so this file can be reused across reposThis avoids the classic
pull_request_targetpwn request problem: the old workflow could execute PR-controlled benchmark/package code while holding base-repository privileges.cc @Krastanov