Skip to content

Make Aqua ignore FiniteDifferences#525

Closed
JamesWrigley wants to merge 1 commit into
JuliaMath:masterfrom
JamesWrigley:patch-2
Closed

Make Aqua ignore FiniteDifferences#525
JamesWrigley wants to merge 1 commit into
JuliaMath:masterfrom
JamesWrigley:patch-2

Conversation

@JamesWrigley

Copy link
Copy Markdown

@devmotion

Copy link
Copy Markdown
Member

IMO that's an issue of how FiniteDifferences runs tests but not a SpecialFunctions issue, hence it should be fixed in FiniteDifferences but not in SpecialFunctions.

@JamesWrigley

Copy link
Copy Markdown
Author

I'm not sure how it could be fixed in FiniteDifferences without something like modifying qa.jl in the tests?

@codecov

codecov Bot commented Mar 29, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.28%. Comparing base (8fb038a) to head (e326c73).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #525   +/-   ##
=======================================
  Coverage   94.28%   94.28%           
=======================================
  Files          14       14           
  Lines        3026     3026           
=======================================
  Hits         2853     2853           
  Misses        173      173           
Flag Coverage Δ
unittests 94.28% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@JamesWrigley

Copy link
Copy Markdown
Author

I removed the JET compat bound in f7eb8a7. I think it'll be less work to keep up with any API changes than ensure that we have compat for the latest Julia version.

@giordano

Copy link
Copy Markdown
Member

Well, that broke the tests again. And I agree with @devmotion this sounds like a problem in FiniteDifferences

@JamesWrigley

Copy link
Copy Markdown
Author

Blegh, reverted. How would you fix it in FiniteDifferences?

@giordano

Copy link
Copy Markdown
Member

I don't know, I haven't looked at what they're doing 🙂

@JamesWrigley

Copy link
Copy Markdown
Author

Hmm could probably make it work with a new environment that dev's both FiniteDifferences and SpecialFunctions.

@devmotion

Copy link
Copy Markdown
Member

Yes, that's what should be done. You have to create a separate (temporary?) environment with both packages and then call Pkg.test with the desired package.

@JamesWrigley

Copy link
Copy Markdown
Author

Closing in favour of the fix in JuliaDiff/FiniteDifferences.jl#248.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants