Skip to content

Harden error boundary actions, add branch-parity rollback CI, and document incident response - #656

Closed
i-amdaveee wants to merge 4 commits into
KCEE0901:developfrom
i-amdaveee:drips/615-616-617-618
Closed

i-amdaveee wants to merge 4 commits into
KCEE0901:developfrom
i-amdaveee:drips/615-616-617-618

Conversation

@i-amdaveee

Copy link
Copy Markdown

Summary

Harden error boundary actions, add branch-parity rollback CI, and document incident response

What was solved

#615 — Add permission-aware action gating to production error boundary coverage

Add permission-aware action gating to the frontend production error boundary coverage: hide or disable actions based on authoritative role and escrow-state checks, scoped to frontend/app, while preserving existing public behavior and keeping logs/errors deterministic and secret-free.

Addressed:

  • Changed: frontend/app/error.tsx, frontend/app/global-error.tsx
  • Scope changes to frontend/app production error boundary coverage only; do not alter behavior outside that surface.
  • Gate actions using authoritative role and escrow-state checks (hide or disable rather than silently allowing).
  • Preserve existing public behavior outside the production error boundary coverage.

#616 — Add privacy-safe interaction telemetry for production error boundary coverage

Add privacy-safe interaction telemetry to the frontend error boundary so production error coverage is measured without capturing wallet addresses or sensitive payloads, with deterministic, secret-free logs and tests covering the success path plus failure/boundary paths.

Addressed:

  • Changed: frontend/app/error.tsx, frontend/app/global-error.tsx
  • Scope changes to frontend/app production error boundary coverage only; preserve existing public behavior elsewhere.
  • Instrument the error boundary to emit privacy-safe telemetry (no wallet addresses, no sensitive payloads, deterministic event shape).
  • Cover the primary success path and at least two failure/boundary paths with automated tests.

#617 — Add rollback validation for main and develop branch parity

Add CI workflow validation that exercises rollback paths and verifies main/develop branch parity, including service health and data consistency checks, with deterministic, secret-free logs and coverage of success plus failure/boundary paths.

Addressed:

  • Changed: .github/workflows/deploy.yml, .github/workflows/release.yml, .github/pull_request_template.md
  • Scope changes to .github/workflows (primarily ci.yml) for main and develop branch parity and rollback validation.
  • Add automated checks that exercise the primary rollback success path and at least two failure/boundary paths (e.g., missing rollback target, health check failure).
  • Verify service health and data consistency after rollback simulation.

#618 — Document incident response for main and develop branch parity

Add incident-response documentation covering detection, containment, recovery, and post-recovery verification for main/develop branch parity, scoped to the .github/workflows area. The issue is documentation-only, so the deliverable is a runbook-style doc (e.g., under .github/ or docs) that references the existing CI/deploy/release workflows and describes how to keep main and develop branches in parity during and after an incident. No workflow behavior changes are required beyond documentation; existing lint/test/build commands must remain green.

Addressed:

  • Changed: .github/workflows/deploy.yml
  • Documentation-only change scoped to main and develop branch parity incident response
  • Provide detection steps (how to notice drift/incident across main and develop, referencing existing workflows)
  • Provide containment steps (freeze/limit changes, protect branches, pause deploys)

Changes

  • .github/workflows/deploy.yml (modify)
  • frontend/app/error.tsx (create)
  • .github/workflows/release.yml (modify)
  • frontend/app/global-error.tsx (create)
  • .github/pull_request_template.md (modify)

Approach

  1. Add permission-aware action gating to production error boundary coverage #615 — Add permission-aware action gating to production error boundary coverage (Changed: frontend/app/error.tsx, frontend/app/global-error.tsx)
  2. Add privacy-safe interaction telemetry for production error boundary coverage #616 — Add privacy-safe interaction telemetry for production error boundary coverage (Changed: frontend/app/error.tsx, frontend/app/global-error.tsx)
  3. Add rollback validation for main and develop branch parity #617 — Add rollback validation for main and develop branch parity (Changed: .github/workflows/deploy.yml, .github/workflows/release.yml, .github/pull_request_template.md)
  4. Document incident response for main and develop branch parity #618 — Document incident response for main and develop branch parity (Changed: .github/workflows/deploy.yml)

Issues

Closes #615
Closes #616
Closes #617
Closes #618

@drips-wave

drips-wave Bot commented Oct 18, 2026

Copy link
Copy Markdown

@i-amdaveee Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@KCEE0901 KCEE0901 closed this Oct 18, 2026
David-Isaac-web pushed a commit to David-Isaac-web/trustchain-escrow that referenced this pull request Oct 22, 2026
…-for-issues-533-532-531-493

Merged by Devdave-0x.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants