Repository navigation
Add PR merge regression detection with scoped permissions and deduped owner notifications - #657
Merged
Merged
Conversation
…elop branch p Closes Devdave-0x#591
…st merge regr Closes Devdave-0x#592
…ge regression Closes Devdave-0x#593
… merge regres Closes Devdave-0x#594
|
@Mac-5 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
David-Isaac-web
pushed a commit
to David-Isaac-web/trustchain-escrow
that referenced
this pull request
Oct 22, 2026
…verage-585-584-583-582 Merged by Devdave-0x.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add PR merge regression detection with scoped permissions and deduped owner notifications
What was solved
#591 — Add failure notification routing for main and develop branch parity
Add failure notification routing to the GitHub Actions workflows so that actionable failures on main and develop branches reach the correct owner without duplicate alerts, while preserving existing behavior outside that parity scope.
Addressed:
#592 — Add configuration preflight checks for pull-request merge regression detection
Add a configuration preflight validation step to the pull-request merge regression detection CI workflow so unsafe or incomplete settings are rejected before any mutation begins, while preserving existing CI behavior and keeping logs deterministic and secret-free.
Addressed:
#593 — Add least-privilege controls for pull-request merge regression detection
Harden the pull-request merge regression detection workflow in .github/workflows/ci.yml by applying least-privilege permissions and credential scoping while preserving existing CI behavior. The change should restrict the workflow/job-level GITHUB_TOKEN permissions to the minimum needed (e.g., contents: read, with pull-requests: read only where PR metadata is required), avoid persisting credentials on checkout where not needed, and ensure any merge-regression detection step runs with only the access it requires. Logs and outputs must remain deterministic and free of secrets. Scope is limited to the CI workflow's PR merge regression detection; no changes to unrelated jobs, other workflows, or application code.
Addressed:
#594 — Add failure notification routing for pull-request merge regression detection
Add a pull-request merge regression detection job to the CI workflow that routes actionable failures to the correct owner (via CODEOWNERS-aware notification) without duplicating alerts, while preserving existing CI behavior. The change is scoped to .github/workflows/ci.yml, adding a regression-detection step/job that runs on pull_request merges, classifies failures, and emits deterministic, secret-free notifications only once per failure.
Addressed:
Changes
.github/workflows/deploy.yml(modify)README.md(modify).github/workflows/release.yml(modify).github/CODEOWNERS(modify)Approach
Issues
Closes #591
Closes #592
Closes #593
Closes #594