Sync Klipper#7232: rp2040: Avoid run-time divides - #1002
Merged
Merged
Conversation
Rework the comparison to avoid using an expensive divide operation. Signed-off-by: Kevin O'Connor <kevin@koconnor.net>
There is no need for elaborate math scaling of the cycle_time value to the local clock ticks. Just hardcode a scale of 16, which simplifies the math calculations. Signed-off-by: Kevin O'Connor <kevin@koconnor.net>
Use a MAX_PWM of 256 (instead of 255) to avoid an expensive run-time divide operation. Signed-off-by: Kevin O'Connor <kevin@koconnor.net>
Use a different method of setting the hardware pwm registers so that the actual cycle_time is much closer to the requested cycle_time. Signed-off-by: Kevin O'Connor <kevin@koconnor.net>
Rework the code slightly to avoid an expensive software divide when calculating the rate in i2c.c . Signed-off-by: Kevin O'Connor <kevin@koconnor.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-picks the upstream rp2040 work to avoid run-time divides, keeping original authorship:
With this the rp2040 no longer needs HAVE_SOFTWARE_DIVIDE_REQUIRED: the build has no software divide left and
check-software-div.shpasses without it.