Repository navigation
fix(exports): export the PS VR2 calls Phasmophobia's psvr2.prx imports - #16
Closed
KernelPanicNT wants to merge 1 commit into
Closed
KernelPanicNT wants to merge 1 commit into
KernelPanicNT wants to merge 1 commit into
Conversation
PPSA09030's Media/Plugins/psvr2.prx imports sceHmd2ReprojectionGetStatus from libSceHmd2 and sceVrTracker2GetCoordinateSystem and sceVrTracker2GetPlayAreaBoundaryGeometry from libSceVrTracker2, so the title does not start with the plugin loaded (discussion boykopovar#4680). Declare the three as throwing exports, like the earlier PS VR2 imports of PPSA29866. The names resolve from the NIDs 8GkaY2B7opM, Y-3JCiU9bbU and SCph4ZbkqzU with tools/nid_names.py; no reference gives their signatures. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Owner
Author
|
Opened upstream as boykopovar#5960. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Phasmophobia (PPSA09030) ships a PS VR2 plugin,
Media/Plugins/psvr2.prx, that imports three calls no library exports, so with--module-dir Media/Pluginsthe executable does not start (current-mainstatus in the Game bring-up thread, 14 October; the workaround there is--exclude-sce-module psvr2.prx). This PR declares them without parameters as throwing stubs (signatures unknown), as boykopovar#4044 did for PPSA07411 and boykopovar#3819 for PPSA29866:libSceHmd28GkaY2B7opMsceHmd2ReprojectionGetStatuslibSceVrTracker2Y-3JCiU9bbUsceVrTracker2GetCoordinateSystemlibSceVrTracker2SCph4ZbkqzUsceVrTracker2GetPlayAreaBoundaryGeometryThe library of each NID comes from the title's load error; the names come from the aerolib NID list (
tools/nid_names.py --nidresolves each NID to these names, and--namecomputes the same NIDs back). No public reference gives their signatures, so nothing beyond the declarations is implemented. Adocs/dev/debt/libSceHmd2.mdentry under Unknown function info lists the three, next to the PPSA29866 one. No test is added, since CONTRIBUTING says not to test that a symbol is exported.If the plugin calls one of these during start-up, the title will now stop on a named
not implementedthrow instead of failing to load the plugin.Tested
Pending: build and NID-patch check of the two libraries and the Windows fork Build workflow; results added here when they finish.
Duplicate and overlap check
Searched open, merged and closed PRs for the three names, their NIDs, PPSA09030 and
psvr2.prx: none declares them. boykopovar#5118 (closed) declared 20 other PS VR2 names, none of these three; boykopovar#4682 and boykopovar#5094 (merged) are the other PPSA09030 changes. No open PR toucheslibSceHmd2/Export.cpp,libSceVrTracker2/Export.cppordocs/dev/debt/libSceHmd2.md.Checklist
main; no other open PR implements the same functionsNotImplemented_nid_no_patch); silent stubs are listed under Silent stubs in their library's technical debt file.mdfiles or images added to the repository (attach them to this PR)psvr2.prx)