Save blueprints via SaveBlueprint on the bulk save path (v17 backport) - #1037
Merged
Conversation
ContentTemplateSerializer overrides SaveItemAsync to save through IContentService.SaveBlueprint, but inherited SaveAsync(IEnumerable<IContent>) from ContentSerializer, which saves through IContentService.Save. That persists the blueprint via DocumentRepository, rewriting umbracoNode.nodeObjectType from DocumentBlueprint to Document, so the next import can no longer find it and fails with a duplicate key error. Backport of #1035 to v17. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #1035 to
v17/main, fixing #1034.ContentTemplateSerializeroverridesSaveItemAsyncto save throughIContentService.SaveBlueprint, but inheritsSaveAsync(IEnumerable<IContent>)fromContentSerializer, which saves throughIContentService.Save.SyncHandlerRoot.PerformSecondPassImportsAsyncuses that bulk overload for any item whose second pass requires a save, so blueprints get persisted viaDocumentRepository. ItsPersistUpdatedItemrebuilds theNodeDtowithDocumentRepository.NodeObjectTypeId, rewritingumbracoNode.nodeObjectTypefromDocumentBlueprinttoDocument.Once that happens
GetBlueprintByIdcan no longer find the item, so the next import treats it as missing and tries to insert it again — failing with a duplicate key onIX_umbracoNode_UniqueId.This overrides
SaveAsyncso the bulk path also goes throughSaveBlueprint, matching thev17style already used bySaveItemAsync(uSyncTaskHelper.FromResultOfwrapper,SaveBlueprint(item, null, userId)).Test plan
uSync.Corebuilds cleanly