Skip to content

Donut: a lost animation frame no longer keeps the slice under a dragged file dark (1.5.1) - #33

Merged
KnifeLemon merged 2 commits into
mainfrom
fix/donut-hover
Oct 3, 2026
Merged

KnifeLemon merged 2 commits into
mainfrom
fix/donut-hover

Conversation

@KnifeLemon

Copy link
Copy Markdown
Owner

What

Reported: Ctrl+drag opened the donut, but the slice under the dragged files didn't light up (and a drop didn't pick it), then a while later it worked again. The donut showing at all means the drag reached the window (in drag mode it stays invisible until files enter it), so the highlight is what failed.

  • The donut's animations run in one frame loop. When a frame request is lost (e.g. requested while the window was hidden), the loop still counted as running and every later animation waited for it, so the highlight springs never moved. A loop without a frame for 250 ms is now treated as stopped and a new one starts; frames of the old loop are ignored.
  • Each drag logs one line: move events, where it ended and how lit that slice was drawn, to tell "the drag never reached the donut" from "it did but nothing lit up" if this comes back.
  • Version 1.5.1, CHANGELOG section.

Tests

New DonutHighlightTests: with the loop marked running and its last frame long ago (a lost frame), the highlighted slice still lights up. App 161.

🤖 Generated with Claude Code

KnifeLemon and others added 2 commits October 4, 2026 03:08
…ed file dark

Reported: Ctrl+drag opened the donut, but the slices didn't light up under the files, then later they did. The
donut's animations run in one frame loop; when a frame request is lost (e.g. requested while the window was
hidden), the loop still counted as running and every later animation waited for it, so the highlight springs never
moved. A loop without a frame for 250 ms is now treated as stopped and a new one starts (frames of the old one are
ignored).

Each drag now also logs one line (move events, where it ended, how lit that slice was drawn), to tell "the drag
never reached the donut" from "it did but nothing lit up" if this comes back.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@KnifeLemon KnifeLemon added the bug Something isn't working label Oct 3, 2026
@KnifeLemon
KnifeLemon merged commit 8b1686b into main Oct 3, 2026
1 check passed
@KnifeLemon
KnifeLemon deleted the fix/donut-hover branch October 3, 2026 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant