Repository navigation
Donut: a lost animation frame no longer keeps the slice under a dragged file dark (1.5.1) - #33
Merged
Merged
Conversation
…ed file dark Reported: Ctrl+drag opened the donut, but the slices didn't light up under the files, then later they did. The donut's animations run in one frame loop; when a frame request is lost (e.g. requested while the window was hidden), the loop still counted as running and every later animation waited for it, so the highlight springs never moved. A loop without a frame for 250 ms is now treated as stopped and a new one starts (frames of the old one are ignored). Each drag now also logs one line (move events, where it ended, how lit that slice was drawn), to tell "the drag never reached the donut" from "it did but nothing lit up" if this comes back. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Reported: Ctrl+drag opened the donut, but the slice under the dragged files didn't light up (and a drop didn't pick it), then a while later it worked again. The donut showing at all means the drag reached the window (in drag mode it stays invisible until files enter it), so the highlight is what failed.
Tests
New
DonutHighlightTests: with the loop marked running and its last frame long ago (a lost frame), the highlighted slice still lights up. App 161.🤖 Generated with Claude Code