Repository navigation
1.7.2: donut highlights pile up and slices fly apart when frames come late - #45
Merged
Merged
Conversation
A spring step covering a late frame (50 ms, the longest the loop allows) overshot more on every frame with the stiffness and damping of the highlight release (since 1.7.1) and of the slice layout. On a busy machine slices stayed lit, piled up in the accent colour and flew apart while closing. Steps now cover at most 1/120 s. Reported on appinn (Windows 11 26H2, gone with "Reduce animations"). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reported on appinn with a video (Windows 11 26H2): slices of the donut stayed lit after the pointer left them, several at once, and flew apart while the donut closed. "Reduce animations" made it go away.
The highlight release spring (stiffness 320, damping 36, since 1.7.1) and the slice layout springs (420, 36) overshoot more on every frame when one integration step covers a late frame (50 ms, the longest the loop allows), so on a busy machine they diverge.
Spring.Stepnow splits a frame into steps of at most 1/120 s.Highlights_settle_when_frames_come_latecrosses the slices with 50 ms frames; it fails without the change.🤖 Generated with Claude Code