Skip to content

Add regression coverage for folder auth inheritance precedence #10000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yaoweiprc merged 2 commits into from
Jun 1, 2026
Merged

Add regression coverage for folder auth inheritance precedence #10000

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4cec0c5
Initial plan
Copilot Jun 1, 2026
3a83e6a
test: add auth inheritance regression coverage
Copilot Jun 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 26 additions & 0 deletions packages/insomnia/src/network/__tests__/network.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1098,6 +1098,32 @@ describe('getCurrentUrl for tough-cookie', () => {
});
});

describe('getOrInheritAuthentication', () => {
it('should prefer the closest parent folder auth over higher-level folder auth', () => {
const request = { authentication: {} };
const requestGroups = [
{ authentication: { type: 'basic', username: 'closest', password: 'closest-pass' } },
{ authentication: { type: 'basic', username: 'root', password: 'root-pass' } },
];

expect(networkUtils.getOrInheritAuthentication({ request, requestGroups })).toEqual({
type: 'basic',
username: 'closest',
password: 'closest-pass',
});
});

it("should stop inheritance when the closest parent folder auth is { type: 'none' }", () => {
const request = { authentication: {} };
const requestGroups = [
{ authentication: { type: 'none' } },
{ authentication: { type: 'basic', username: 'root', password: 'root-pass' } },
];

expect(networkUtils.getOrInheritAuthentication({ request, requestGroups })).toEqual({ type: 'none' });
});
});

describe('getOrInheritHeaders', () => {
it('should combine headers', () => {
const requestGroups = [{ headers: [{ name: 'foo', value: 'bar' }] }, { headers: [{ name: 'baz', value: 'qux' }] }];
Expand Down
Loading