Containerized controller#434
Merged
Merged
Conversation
enhaut
force-pushed
the
nv
branch
3 times, most recently
from
774646d to
a79f803
Compare
enhaut
force-pushed
the
nv
branch
2 times, most recently
from
cc086da to
1dcc4e1
Compare
Call `machine_cleanup()` before `accept_connection()` to destroy the old `InterfaceManager` and its netlink socket. Without this, stale netlink events accumulate in the buffer and get forwarded to the new controller eventhough message is irrelevant for current controller session. Resolves: LNST-project#433
enhaut
force-pushed
the
nv
branch
2 times, most recently
from
e5f004b to
ba2090e
Compare
jtluka
reviewed
Jun 2, 2026
jtluka
left a comment
jtluka
left a comment
Collaborator
There was a problem hiding this comment.
Overall OK, just minor issues and suggestions.
Axonis
reviewed
Jun 8, 2026
Axonis
left a comment
Axonis
left a comment
Collaborator
There was a problem hiding this comment.
Overall looks good, just nits.
enhaut
force-pushed
the
nv
branch
2 times, most recently
from
a84ca74 to
b0351ed
Compare
jtluka
previously approved these changes
Jun 9, 2026
Axonis
previously approved these changes
Jun 10, 2026
olichtne
reviewed
Jun 10, 2026
olichtne
reviewed
Jun 10, 2026
olichtne
reviewed
Jun 10, 2026
olichtne
reviewed
Jun 10, 2026
olichtne
reviewed
Jun 10, 2026
olichtne
requested changes
Jun 10, 2026
This should be integrated into the Controller container to automatically create a temporary pool from a single input file that will be used by the controller runner. Signed-off-by: Ondrej Lichtner <olichtne@redhat.com>
Added support for controller to pick up tests from `test_db.py` file.
Containerized controller now parses `test_environment.json` file with list of hosts that are supposed to be used in test. Controller tries to ssh into that machines with either ssh keys (these needs to be mounted in contianer's `~/.ssh/`) or password provided in plaintext in `test_environment.json` file. If LNST is already installed on remote agents, nothing happens. It just checks whether it's running.
olichtne
approved these changes
Jun 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Better support for controller containerization. Now, it suports agent auto setup by
test_environment.jsonfile and also tests db defined intest_db.jsonfile. Container is build and after merging its pushed to quay https://quay.io/repository/lnst/lnst-controller repository (takes ~5minutes). Both:latestand:commit shamanifests are created, commit sha manifest refers to build based on specific LNST version on both controller and agents.Tests
Ran locally against agents without LNST. It installed LNST and ran tests defined in test db:
Resolves #433