lnst/Common/Logs.py: reset export logger between set/unset_recipe#442
Merged
Conversation
olichtne
reviewed
May 12, 2026
olichtne
reviewed
May 12, 2026
Without this the export_handler logger handler would append all recipes executed by a single Controller instance into a shared list. The export_handler initialization/teardown is moved to set_recipe() and unset_recipe() methods to avoid that. Signed-off-by: Jan Tluka <jtluka@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Without this the export_handler logger handler would append all recipes executed by a single Controller instance into a shared list.
The export_handler initialization/teardown is moved to set_recipe() and unset_recipe() methods to avoid that.
Tests
Tested locally with attached script: test-containers.py
And then inspecting the log files with another script: dump-lrc-log.py
In the dumped logs, check for
Summary of used Recipe parameters... the second dump will include also run from previous recipe (ipv6 AND ipv4).Reviews
@olichtne @enhaut @Axonis