Fix condition to check for negative nz_use values#38
Merged
Conversation
Instead of just non-positive, so we now allow zero.
Contributor
Author
|
Sorry about the newline change, the github online editor did it without asking. |
nikosarcevic
approved these changes
Jun 9, 2026
nikosarcevic
left a comment
nikosarcevic
left a comment
Collaborator
There was a problem hiding this comment.
did you check if this also works with differnt binny configs? in any case i can approve this -- but i will have to confirm later if I need to check in binny. thanks, joe
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of just non-positive, so we now allow zero.
Fixes issue #37