Skip to content

Fix popup width and incognito image - #33

Merged
LTDigor merged 1 commit into
mainfrom
codex/fix-incognito-block-page
Jul 29, 2026
Merged

LTDigor merged 1 commit into
mainfrom
codex/fix-incognito-block-page

Conversation

@LTDigor

@LTDigor LTDigor commented Jul 29, 2026

Copy link
Copy Markdown
Owner

Summary

  • Reserve scrollbar gutter so expanding a tall blocked-sites list does not widen the popup.
  • Preserve the popup document's already-resolved default image URL instead of replacing it with a regular-context runtime URL.
  • Add regressions for stable popup width and incognito image URL handling.

Root cause

The popup had a fixed 360 px body but did not reserve space for a vertical scrollbar, so opening a tall blocked-sites list changed the popup's outer width. Separately, popup initialization replaced the image element's incognito-resolved URL with runtime.getURL(...), unlike the blocked-page fix already used elsewhere.

Validation

  • npm test — 101 tests passed.
  • npm run package — Chromium and Firefox archives built.
  • Rendered popup QA at 360 px: width stayed 360 px before and after expanding 9 rules.
  • Default preview decoded successfully (naturalWidth = 1280).
  • No relevant console warnings or errors.

@coderabbitai

coderabbitai Bot commented Jul 29, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 2ab1336a-ec2c-4bd4-a8c2-86b744e5a0a4

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@LTDigor
LTDigor merged commit 1f1f469 into main Jul 29, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant