Skip to content

Fix popup expansion at root width - #34

Merged
LTDigor merged 1 commit into
mainfrom
codex/fix-popup-expansion-regression
Jul 29, 2026
Merged

LTDigor merged 1 commit into
mainfrom
codex/fix-popup-expansion-regression

Conversation

@LTDigor

@LTDigor LTDigor commented Jul 29, 2026

Copy link
Copy Markdown
Owner

Summary

  • Lock the popup root to 360 px instead of relying on a scrollbar gutter.
  • Prevent Chrome from expanding the popup viewport around a still-360 px body.
  • Replace the misleading width test with the actual root-width invariant.
  • Add a rendered Chrome regression that opens the real popup UI at an 800 px host viewport, adds the five rules from the reported screenshots, expands the list, and verifies root/body width remains 360 px.

Root cause

The body was fixed at 360 px, but the root element remained auto-sized. When Chrome widened the extension-popup viewport to 800 px after the list became taller than the popup limit, the body/cards stayed 360 px and the root filled 800 px, creating the large blank area on the right. scrollbar-gutter: stable did not constrain the root and therefore did not fix the bug.

Validation

  • Browser regression demonstrated RED before the fix: root width was 800 px.
  • Browser regression is GREEN after the fix: root/body stay 360 px collapsed and expanded.
  • Headed extension action popup: outer width 374 → 374 px; root/body 360 → 360 px.
  • npm test: 102 tests passed, 0 failed, 0 skipped.
  • npm run package: Chromium and Firefox archives built.
  • No relevant console warnings or errors.

@coderabbitai

coderabbitai Bot commented Jul 29, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: f2bc2c8e-8d34-442e-9b58-01358594cc57

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@LTDigor
LTDigor force-pushed the codex/fix-popup-expansion-regression branch from cf4a2cd to c911266 Compare July 29, 2026 01:05
@LTDigor
LTDigor merged commit fba4e50 into main Jul 29, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant