[LWDM] chore(analytics-consent): remove consentValidityDays and live-common

.changeset/swift-badgers-clear.md

@@ -0,0 +1,9 @@
+---
+"@shared/feature-flags": patch
+"@ledgerhq/live-common": patch
+"@features/flow-analytics-consent": patch
+"ledger-live-desktop": patch
+"live-mobile": patch
+---
+
+Remove analytics consentValidityDays and the unused live-common consent expiry helpers

CODEOWNERS

@@ -506,7 +506,6 @@ libs/live-engagement/
 
 ## Common
 libs/ledger-live-common/src/braze/                                                             @ledgerhq/engagement
-libs/ledger-live-common/src/analyticsConsent/                                                  @ledgerhq/engagement
 libs/ledger-live-common/src/analytics/                                                         @ledgerhq/engagement
 libs/ledger-live-common/src/genericAwarenessModal/                                             @ledgerhq/engagement
 libs/ledger-live-common/src/onboarding/                                                        @ledgerhq/engagement

apps/ledger-live-desktop/src/mvvm/features/AnalyticsConsentDialog/__integrations__/AnalyticsConsentDialog.portfolio.integration.test.tsx

@@ -658,8 +658,6 @@ describe("AnalyticsConsentDialog on portfolio route", () => {
           params: {
             ...FEATURE_FLAGS_DEFAULTS.analyticsOptIn.params,
             policyVersion: "1.1",
-            consentValidityDays:
-              FEATURE_FLAGS_DEFAULTS.analyticsOptIn.params?.consentValidityDays ?? 365,
           },
         },
       },
@@ -671,8 +669,6 @@ describe("AnalyticsConsentDialog on portfolio route", () => {
           params: {
             ...FEATURE_FLAGS_DEFAULTS.analyticsOptIn.params,
             policyVersion: "1.1",
-            consentValidityDays:
-              FEATURE_FLAGS_DEFAULTS.analyticsOptIn.params?.consentValidityDays ?? 365,
           },
         },
       },

apps/ledger-live-desktop/src/mvvm/features/AnalyticsConsentDialog/__tests__/useAnalyticsConsentDialogViewModel.test.ts

@@ -53,25 +53,21 @@ const featureFlagsWithMinorBump = {
     ...analyticsOptInOverrides,
     analyticsOptIn: {
       ...analyticsOptInOverrides.analyticsOptIn,
-      params: {
-        ...FEATURE_FLAGS_DEFAULTS.analyticsOptIn.params,
-        policyVersion: "1.1",
-        consentValidityDays:
-          FEATURE_FLAGS_DEFAULTS.analyticsOptIn.params?.consentValidityDays ?? 365,
-      },
+        params: {
+          ...FEATURE_FLAGS_DEFAULTS.analyticsOptIn.params,
+          policyVersion: "1.1",
+        },
     },
   },
   resolved: {
     ...FEATURE_FLAGS_DEFAULTS,
     ...analyticsOptInOverrides,
     analyticsOptIn: {
       ...analyticsOptInOverrides.analyticsOptIn,
-      params: {
-        ...FEATURE_FLAGS_DEFAULTS.analyticsOptIn.params,
-        policyVersion: "1.1",
-        consentValidityDays:
-          FEATURE_FLAGS_DEFAULTS.analyticsOptIn.params?.consentValidityDays ?? 365,
-      },
+        params: {
+          ...FEATURE_FLAGS_DEFAULTS.analyticsOptIn.params,
+          policyVersion: "1.1",
+        },
     },
   },
 };
@@ -179,8 +175,6 @@ describe("useAnalyticsConsentDialogViewModel", () => {
             params: {
               ...FEATURE_FLAGS_DEFAULTS.analyticsOptIn.params,
               policyVersion: "2.0",
-              consentValidityDays:
-                FEATURE_FLAGS_DEFAULTS.analyticsOptIn.params?.consentValidityDays ?? 365,
             },
           },
         },
@@ -192,8 +186,6 @@ describe("useAnalyticsConsentDialogViewModel", () => {
             params: {
               ...FEATURE_FLAGS_DEFAULTS.analyticsOptIn.params,
               policyVersion: "2.0",
-              consentValidityDays:
-                FEATURE_FLAGS_DEFAULTS.analyticsOptIn.params?.consentValidityDays ?? 365,
             },
           },
         },

apps/ledger-live-desktop/src/renderer/reducers/settings.test.ts

@@ -682,7 +682,7 @@ describe("trackingEnabledSelector", () => {
               lastAnalyticsConsentDate: FIXED_NOW.toISOString(),
               privacyPolicyVersion: "1.0",
             },
-            { params: { policyVersion: "2.0", consentValidityDays: 365 } },
+            { params: { policyVersion: "2.0" } },
           ),
         ),
       ).toBe(false);
@@ -698,7 +698,7 @@ describe("trackingEnabledSelector", () => {
               lastAnalyticsConsentDate: FIXED_NOW.toISOString(),
               privacyPolicyVersion: "1.0",
             },
-            { params: { policyVersion: "1.1", consentValidityDays: 365 } },
+            { params: { policyVersion: "1.1" } },
           ),
         ),
       ).toBe(true);
@@ -714,7 +714,7 @@ describe("trackingEnabledSelector", () => {
               lastAnalyticsConsentDate: FIXED_NOW.toISOString(),
               privacyPolicyVersion: "1.0",
             },
-            { params: { policyVersion: "not-a-version", consentValidityDays: 365 } },
+            { params: { policyVersion: "not-a-version" } },
           ),
         ),
       ).toBe(true);

apps/ledger-live-desktop/src/renderer/screens/settings/sections/Developer/AnalyticsConsentOptInDevTool/AnalyticsConsentOptInDevScreen.tsx

@@ -25,7 +25,6 @@ const COPY = {
   title: "Analytics opt-in consent — QA",
   readSection: "Current settings (read-only)",
   currentPrivacyVersion: (version: string) => `App current privacy policy version: ${version}`,
-  currentConsentValidityDays: (days: string) => `App current consent validity (days): ${days}`,
   storedPrivacyVersion: (version: string) => `Stored privacy policy version: ${version}`,
   consentDate: (value: string) => `Consent date (raw): ${value}`,
   decision: (value: string) => `Shared decision: ${value}`,
@@ -55,13 +54,6 @@ const formatConsentDate = (value: string | null) => {
   return value;
 };
 
-function readConsentValidityDays(feature: { params?: unknown } | null | undefined): string {
-  const params = feature?.params;
-  if (!params || typeof params !== "object") return "n/a";
-  const days = (params as { consentValidityDays?: unknown }).consentValidityDays;
-  return days == null ? "n/a" : String(days);
-}
-
 export function AnalyticsConsentOptInDevScreen() {
   const navigate = useNavigate();
   const dispatch = useDispatch();
@@ -71,7 +63,6 @@ export function AnalyticsConsentOptInDevScreen() {
   const analyticsOptInFeature = useFeature("analyticsOptIn");
   const { currentPolicyVersion } = resolveAnalyticsOptInParams(analyticsOptInFeature);
   const decision = getAnalyticsConsentDecision(consentInfo, { currentPolicyVersion });
-  const consentValidityDays = readConsentValidityDays(analyticsOptInFeature);
 
   const shouldOfferModal =
     Boolean(analyticsOptInFeature?.enabled) && hasCompletedOnboarding && decision.kind !== "none";
@@ -147,9 +138,6 @@ export function AnalyticsConsentOptInDevScreen() {
             <p className="body-2 leading-relaxed text-muted">
               {COPY.currentPrivacyVersion(currentPolicyVersion?.normalized ?? "null")}
             </p>
-            <p className="body-2 leading-relaxed text-muted">
-              {COPY.currentConsentValidityDays(consentValidityDays)}
-            </p>
             <p className="body-2 leading-relaxed text-muted">
               {COPY.decision(`${decision.kind} (${decision.reason})`)}
             </p>

apps/ledger-live-mobile/src/mvvm/features/AnalyticsConsentDrawer/__tests__/useAnalyticsConsentDrawerViewModel.test.ts

@@ -9,7 +9,7 @@ import {
 } from "../hooks/useAnalyticsConsentDrawerViewModel";
 import { withConsentDrawerOpeningFresh, withConsentDrawerState } from "./helpers";
 
-/** Fixed clock so `needsConsentRenewal` / consent ISO strings are deterministic. */
+/** Fixed clock so consent ISO strings are deterministic. */
 const FIXED_NOW = new Date("2024-01-15T12:00:00.000Z");
 
 const drawerEventPayload = {

features/flow/analytics-consent/README.md

@@ -8,9 +8,7 @@ acknowledge a new privacy policy, or stay silent. Implements
 [ADR: Analytics Consent Renewal](https://ledgerhq.atlassian.net/wiki/spaces/Engagement/pages/7249592355):
 `analyticsOptIn.params.policyVersion` carries major/minor semantics.
 
-Renewal is version-driven only. A stored consent never expires on a timer, so
-`analyticsOptIn.params.consentValidityDays` is not read here — it remains for desktop, which
-still runs its own rolling window through `libs/ledger-live-common`.
+Renewal is version-driven only. A stored consent never expires on a timer.
 
 One verdict drives both the consent drawer and the tracking gate, so optional analytics is
 disabled exactly while a fresh choice is pending.

features/flow/analytics-consent/package.json

@@ -2,7 +2,7 @@
   "name": "@features/flow-analytics-consent",
   "version": "0.1.0",
   "private": true,
-  "description": "Analytics consent decision engine: policy version major/minor semantics plus rolling consent expiry",
+  "description": "Analytics consent decision engine: policy version major/minor semantics",
   "main": "src/index.ts",
   "types": "src/index.ts",
   "exports": {

features/flow/analytics-consent/src/utils/resolveAnalyticsOptInParams.test.ts

@@ -23,7 +23,7 @@ describe("resolveAnalyticsOptInParams", () => {
     });
   });
 
-  it("ignores params the mobile decision no longer reads", () => {
+  it("ignores unknown params (e.g. legacy consentValidityDays)", () => {
     expect(
       resolveAnalyticsOptInParams({ params: { policyVersion: 2, consentValidityDays: 730 } }),
     ).toEqual({ currentPolicyVersion: { major: 2, minor: 0, normalized: "2.0" } });

libs/ledger-live-common/.unimportedrc.json

@@ -7,7 +7,6 @@
     "src/analytics/featureFlagHelpers/onboardingCounterfeitWarning.ts",
     "src/analytics/featureFlagHelpers/wallet40.ts",
     "src/analytics/fundsReceived.ts",
-    "src/analyticsConsent/index.ts",
     "src/apps/filtering.ts",
     "src/apps/formatting.ts",
     "src/apps/hw.ts",