Skip to content

[LWM] fix(animations): bump react-native-reanimated to 4.3.3 (LIVE-35218) - #20270

Draft
LucasWerey wants to merge 1 commit into
developfrom
fix/animations-LIVE-35218-bump-reanimated-4-3-3
Draft

[LWM] fix(animations): bump react-native-reanimated to 4.3.3 (LIVE-35218)#20270
LucasWerey wants to merge 1 commit into
developfrom
fix/animations-LIVE-35218-bump-reanimated-4-3-3

Conversation

@LucasWerey

@LucasWerey LucasWerey commented Jul 31, 2026

Copy link
Copy Markdown
Member

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests. Dependency bump only — no application code changed. The fix targets a runtime animation race that unit tests cannot reproduce.
  • Impact of the changes:
    - Portfolio cold start: balance and Fear & Greed / Altcoin Season arc animations
    - Any Reanimated-driven animation across the app (the bump is app-wide)
    - Android startup — patches/react-native-worklets@0.8.1.patch must still apply

📝 Description

Some Portfolio animations do not always play on a cold start — the behaviour is intermittent and shows up mostly when the JS thread is busy at startup.

Reanimated 4.3.0 has an animation cancellation race that can stop an animation started from a mount-time effect before it runs. This bumps react-native-reanimated from 4.3.0 to 4.3.3, which includes the fix.

react-native-worklets stays on 0.8.1 (4.3.3 peers on 0.8.x), so the existing worklets patch is unaffected. No other package resolution changed.

This is an attempt at a fix — it needs to be validated on device before we know whether it fully resolves the issue.

❓ Context


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

Copilot AI review requested due to automatic review settings July 31, 2026 08:24
@LucasWerey
LucasWerey marked this pull request as ready for review July 31, 2026 08:26

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR bumps react-native-reanimated from 4.3.0 to 4.3.3 across the monorepo via the pnpm catalog, aiming to fix an intermittent cold-start animation cancellation race affecting Reanimated-driven animations (notably in Portfolio).

Changes:

  • Update pnpm catalog entry for react-native-reanimated to 4.3.3.
  • Regenerate pnpm-lock.yaml to resolve react-native-reanimated@4.3.3 (and associated dependency graph updates).
  • Add a changeset to publish a patch release for live-mobile.

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.

File Description
pnpm-workspace.yaml Updates the catalog version for react-native-reanimated to 4.3.3.
pnpm-lock.yaml Updates the lockfile to resolve react-native-reanimated@4.3.3 and refresh related resolutions/metadata.
.changeset/bump-reanimated-4-3-3.md Declares a patch changeset for live-mobile documenting the dependency bump.

Comment thread pnpm-lock.yaml
Comment thread pnpm-lock.yaml
ysitbon
ysitbon previously approved these changes Jul 31, 2026
@github-actions

github-actions Bot commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

Web Tools Build Status

Build Status Deployment
Web Tools Build ✅ Deployed https://web-tools-9p96iym8b-ledger-hq-prd.vercel.app
Native Storybook Build ✅ Deployed https://native-ui-storybook-ducipzv4q-ledger-hq-prd.vercel.app
React Storybook Build ✅ Deployed https://react-ui-storybook-7xn07933z-ledger-hq-prd.vercel.app

Copilot AI review requested due to automatic review settings July 31, 2026 08:30
@LucasWerey
LucasWerey force-pushed the fix/animations-LIVE-35218-bump-reanimated-4-3-3 branch from b380d72 to 281b151 Compare July 31, 2026 08:30
@LucasWerey
LucasWerey requested a review from a team as a code owner July 31, 2026 08:30
@live-github-bot live-github-bot Bot added the mobile Has changes in LLM label Jul 31, 2026
@live-github-bot live-github-bot Bot changed the title fix(animations): bump react-native-reanimated to 4.3.3 (LIVE-35218) [LWM] fix(animations): bump react-native-reanimated to 4.3.3 (LIVE-35218) Jul 31, 2026
@github-actions

Copy link
Copy Markdown
Contributor

⚠️ E2E tests are required

Changes detected require e2e testing before merge (even before asking for any review).

🖥️ Desktop

-> Run Desktop E2E

  • Select "Run workflow"
  • Branch: fix/animations-LIVE-35218-bump-reanimated-4-3-3
  • Device: nanoSP or stax

📱 Mobile

-> Run Mobile E2E

  • Select "Run workflow"
  • Branch: fix/animations-LIVE-35218-bump-reanimated-4-3-3
  • Device: nanoX

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 4 changed files in this pull request and generated no new comments.

@github-actions

github-actions Bot commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

Rsdoctor Bundle Diff Analysis

Found 7 projects in monorepo, 7 projects with changes.

📊 Quick Summary
Project Total Size Change
desktop-main 2.3 MB -
desktop-preloader 7.1 KB -
desktop-renderer 80.6 MB -
desktop-webviewDappPreloader 36.9 KB -
desktop-webviewPreloader 200.0 B -
desktop-workers 36.8 KB -
mobile 261.3 MB -
📋 Detailed Reports (Click to expand)

📁 desktop-main

Path: rsdoctor/desktop-main/rsdoctor-data.json

⚠️ No baseline data found - Unable to perform comparison analysis

Metric Current Baseline Change
📊 Total Size 2.3 MB - -
📄 JavaScript 2.2 MB - -
🎨 CSS 0 B - -
🌐 HTML 0 B - -
📁 Other Assets 135.3 KB - -

📁 desktop-preloader

Path: rsdoctor/desktop-preloader/rsdoctor-data.json

⚠️ No baseline data found - Unable to perform comparison analysis

Metric Current Baseline Change
📊 Total Size 7.1 KB - -
📄 JavaScript 5.3 KB - -
🎨 CSS 0 B - -
🌐 HTML 0 B - -
📁 Other Assets 1.8 KB - -

📁 desktop-renderer

Path: rsdoctor/desktop-renderer/rsdoctor-data.json

⚠️ No baseline data found - Unable to perform comparison analysis

Metric Current Baseline Change
📊 Total Size 80.6 MB - -
📄 JavaScript 29.3 MB - -
🎨 CSS 183.1 KB - -
🌐 HTML 1.8 KB - -
📁 Other Assets 51.2 MB - -

📁 desktop-webviewDappPreloader

Path: rsdoctor/desktop-webviewDappPreloader/rsdoctor-data.json

⚠️ No baseline data found - Unable to perform comparison analysis

Metric Current Baseline Change
📊 Total Size 36.9 KB - -
📄 JavaScript 36.9 KB - -
🎨 CSS 0 B - -
🌐 HTML 0 B - -
📁 Other Assets 0 B - -

📁 desktop-webviewPreloader

Path: rsdoctor/desktop-webviewPreloader/rsdoctor-data.json

⚠️ No baseline data found - Unable to perform comparison analysis

Metric Current Baseline Change
📊 Total Size 200.0 B - -
📄 JavaScript 200.0 B - -
🎨 CSS 0 B - -
🌐 HTML 0 B - -
📁 Other Assets 0 B - -

📁 desktop-workers

Path: rsdoctor/desktop-workers/rsdoctor-data.json

⚠️ No baseline data found - Unable to perform comparison analysis

Metric Current Baseline Change
📊 Total Size 36.8 KB - -
📄 JavaScript 36.8 KB - -
🎨 CSS 0 B - -
🌐 HTML 0 B - -
📁 Other Assets 0 B - -

📁 mobile

Path: rsdoctor/mobile/rsdoctor-data.json

⚠️ No baseline data found - Unable to perform comparison analysis

Metric Current Baseline Change
📊 Total Size 261.3 MB - -
📄 JavaScript 110.4 MB - -
🎨 CSS 0 B - -
🌐 HTML 0 B - -
📁 Other Assets 150.9 MB - -

Generated by Rsdoctor GitHub Action

Copilot AI review requested due to automatic review settings July 31, 2026 08:48
@LucasWerey
LucasWerey force-pushed the fix/animations-LIVE-35218-bump-reanimated-4-3-3 branch from 281b151 to bfed41e Compare July 31, 2026 08:48
@LucasWerey
LucasWerey requested a review from a team as a code owner July 31, 2026 08:48
@github-actions

Copy link
Copy Markdown
Contributor

❌ Action Required: Monitored Files Changed

The following files in monitored folders have been modified:

  • .github/workflows/danger.yml

Action Required: Please rebase your branch against develop to ensure consistency:

git rebase origin/develop

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 5 changed files in this pull request and generated no new comments.

@LucasWerey
LucasWerey marked this pull request as draft July 31, 2026 09:03
@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

mobile Has changes in LLM

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants