[LWD] fix(lwd): add explicit type annotations in test files - #20288
Conversation
Web Tools Build Status
|
There was a problem hiding this comment.
Pull request overview
This PR targets TypeScript typecheck stability in Ledger Wallet Desktop by adding explicit type annotations in Jest test callbacks (notably .map()/.filter()), and includes a changeset for a patch bump.
Changes:
- Add explicit callback parameter annotations in desktop test files to satisfy stricter TS inference/typecheck.
- Update the contacts devtool hook test assertions around the populated contacts list (currently inconsistent with the underlying mock fixture).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| apps/ledger-live-desktop/src/renderer/screens/settings/sections/Developer/ContactsDevTool/hooks/tests/useContactsDevToolViewModel.test.ts | Adds a Contact type annotation in a .map() callback, but also changes expected populated contacts count/names. |
| apps/ledger-live-desktop/src/mvvm/features/FinishOnboarding/RecoverWidget/tests/usePortfolioAddRecoverPostOnboardingAction.test.ts | Adds explicit PostOnboardingActionId typing to a .filter() callback in a test assertion. |
| .changeset/golden-trees-jump.md | Declares a patch changeset for ledger-live-desktop describing typecheck fixes in tests. |
Rsdoctor Bundle Diff AnalysisFound 7 projects in monorepo, 7 projects with changes. 📊 Quick Summary
📋 Detailed Reports (Click to expand)📁 desktop-mainPath:
📁 desktop-preloaderPath:
📁 desktop-rendererPath:
📁 desktop-webviewDappPreloaderPath:
📁 desktop-webviewPreloaderPath:
📁 desktop-workersPath:
📁 mobilePath:
Generated by Rsdoctor GitHub Action |
fdf4959 to
bdf35db
Compare
bdf35db to
5d139b9
Compare
|



📝 Description
Add explicit type annotations to
.filter()and.map()callbacks in desktop test files🔗 Context