Skip to content

[LWD] fix(lwd): add explicit type annotations in test files - #20288

Merged
Sebastien-Dav1d merged 1 commit into
developfrom
fix/lwd/typecheck-issue
Aug 3, 2026
Merged

[LWD] fix(lwd): add explicit type annotations in test files#20288
Sebastien-Dav1d merged 1 commit into
developfrom
fix/lwd/typecheck-issue

Conversation

@Sebastien-Dav1d

Copy link
Copy Markdown
Contributor

📝 Description

Add explicit type annotations to .filter() and .map() callbacks in desktop test files

🔗 Context

  • JIRA / GitHub issue:
  • ADR (if any):

Copilot AI review requested due to automatic review settings July 31, 2026 13:43
@live-github-bot live-github-bot Bot added the desktop Has changes in LLD label Jul 31, 2026
@live-github-bot live-github-bot Bot changed the title fix(lwd): add explicit type annotations in test files [LWD] fix(lwd): add explicit type annotations in test files Jul 31, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Web Tools Build Status

Build Status Deployment
Web Tools Build ⏭️ Skipped
Native Storybook Build ⏭️ Skipped
React Storybook Build ⏭️ Skipped

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR targets TypeScript typecheck stability in Ledger Wallet Desktop by adding explicit type annotations in Jest test callbacks (notably .map()/.filter()), and includes a changeset for a patch bump.

Changes:

  • Add explicit callback parameter annotations in desktop test files to satisfy stricter TS inference/typecheck.
  • Update the contacts devtool hook test assertions around the populated contacts list (currently inconsistent with the underlying mock fixture).

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
apps/ledger-live-desktop/src/renderer/screens/settings/sections/Developer/ContactsDevTool/hooks/tests/useContactsDevToolViewModel.test.ts Adds a Contact type annotation in a .map() callback, but also changes expected populated contacts count/names.
apps/ledger-live-desktop/src/mvvm/features/FinishOnboarding/RecoverWidget/tests/usePortfolioAddRecoverPostOnboardingAction.test.ts Adds explicit PostOnboardingActionId typing to a .filter() callback in a test assertion.
.changeset/golden-trees-jump.md Declares a patch changeset for ledger-live-desktop describing typecheck fixes in tests.

@github-actions

github-actions Bot commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

Rsdoctor Bundle Diff Analysis

Found 7 projects in monorepo, 7 projects with changes.

📊 Quick Summary
Project Total Size Change
desktop-main 2.3 MB -
desktop-preloader 7.1 KB -
desktop-renderer 80.6 MB -
desktop-webviewDappPreloader 36.9 KB -
desktop-webviewPreloader 200.0 B -
desktop-workers 36.8 KB -
mobile 261.4 MB -
📋 Detailed Reports (Click to expand)

📁 desktop-main

Path: rsdoctor/desktop-main/rsdoctor-data.json

⚠️ No baseline data found - Unable to perform comparison analysis

Metric Current Baseline Change
📊 Total Size 2.3 MB - -
📄 JavaScript 2.2 MB - -
🎨 CSS 0 B - -
🌐 HTML 0 B - -
📁 Other Assets 135.3 KB - -

📁 desktop-preloader

Path: rsdoctor/desktop-preloader/rsdoctor-data.json

⚠️ No baseline data found - Unable to perform comparison analysis

Metric Current Baseline Change
📊 Total Size 7.1 KB - -
📄 JavaScript 5.3 KB - -
🎨 CSS 0 B - -
🌐 HTML 0 B - -
📁 Other Assets 1.8 KB - -

📁 desktop-renderer

Path: rsdoctor/desktop-renderer/rsdoctor-data.json

⚠️ No baseline data found - Unable to perform comparison analysis

Metric Current Baseline Change
📊 Total Size 80.6 MB - -
📄 JavaScript 29.3 MB - -
🎨 CSS 183.1 KB - -
🌐 HTML 1.8 KB - -
📁 Other Assets 51.2 MB - -

📁 desktop-webviewDappPreloader

Path: rsdoctor/desktop-webviewDappPreloader/rsdoctor-data.json

⚠️ No baseline data found - Unable to perform comparison analysis

Metric Current Baseline Change
📊 Total Size 36.9 KB - -
📄 JavaScript 36.9 KB - -
🎨 CSS 0 B - -
🌐 HTML 0 B - -
📁 Other Assets 0 B - -

📁 desktop-webviewPreloader

Path: rsdoctor/desktop-webviewPreloader/rsdoctor-data.json

⚠️ No baseline data found - Unable to perform comparison analysis

Metric Current Baseline Change
📊 Total Size 200.0 B - -
📄 JavaScript 200.0 B - -
🎨 CSS 0 B - -
🌐 HTML 0 B - -
📁 Other Assets 0 B - -

📁 desktop-workers

Path: rsdoctor/desktop-workers/rsdoctor-data.json

⚠️ No baseline data found - Unable to perform comparison analysis

Metric Current Baseline Change
📊 Total Size 36.8 KB - -
📄 JavaScript 36.8 KB - -
🎨 CSS 0 B - -
🌐 HTML 0 B - -
📁 Other Assets 0 B - -

📁 mobile

Path: rsdoctor/mobile/rsdoctor-data.json

⚠️ No baseline data found - Unable to perform comparison analysis

Metric Current Baseline Change
📊 Total Size 261.4 MB - -
📄 JavaScript 110.4 MB - -
🎨 CSS 0 B - -
🌐 HTML 0 B - -
📁 Other Assets 151.0 MB - -

Generated by Rsdoctor GitHub Action

Copilot AI review requested due to automatic review settings July 31, 2026 13:56
@Sebastien-Dav1d
Sebastien-Dav1d force-pushed the fix/lwd/typecheck-issue branch from fdf4959 to bdf35db Compare July 31, 2026 13:57

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

Copilot AI review requested due to automatic review settings July 31, 2026 14:08
@Sebastien-Dav1d
Sebastien-Dav1d force-pushed the fix/lwd/typecheck-issue branch from bdf35db to 5d139b9 Compare July 31, 2026 14:08

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.

@sonarqubecloud

Copy link
Copy Markdown

@Sebastien-Dav1d
Sebastien-Dav1d marked this pull request as ready for review July 31, 2026 14:25
@Sebastien-Dav1d
Sebastien-Dav1d requested review from a team as code owners July 31, 2026 14:25
@Sebastien-Dav1d
Sebastien-Dav1d merged commit 0636166 into develop Aug 3, 2026
67 checks passed
@Sebastien-Dav1d
Sebastien-Dav1d deleted the fix/lwd/typecheck-issue branch August 3, 2026 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

desktop Has changes in LLD

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants