Skip to content

feat: add local 1Password shell plugin support - #14

Merged
Leechael merged 3 commits into
mainfrom
feat/1password-shell-plugin
Jun 18, 2026
Merged

feat: add local 1Password shell plugin support#14
Leechael merged 3 commits into
mainfrom
feat/1password-shell-plugin

Conversation

@Leechael

@Leechael Leechael commented Jun 15, 2026

Copy link
Copy Markdown
Owner

Summary

  • Add a local 1Password shell plugin module for roam-cli
  • Add roam-cli onepassword install to copy the local plugin binary
  • Add plugin build/test Makefile targets, docs, and release bundling

Test Results

  • make ci passed
  • make op-plugin-build passed
  • prek run --all-files passed

Test Coverage

  • Plugin schema, credential mapping, importer, and needs-auth behavior covered
  • Main install command error paths, copy behavior, force overwrite, output, and permissions covered

Review Findings

  • No blocking issues found

Test Plan

  • All tests pass
  • Coverage audit complete
  • Pre-ship review clean

Summary by cubic

Adds local 1Password shell plugin support for roam-cli so users can auto-inject credentials via op without managing .env files. Includes a new install command, plugin module, tests, docs (with env-var and shell plugin paths), and release bundling of both binaries.

  • New Features

    • Local plugin at contrib/1password-plugin (builds roamresearch) with credential mapping and executable schema; ignores help/version/completion for auth.
    • New roam-cli onepassword install (flags: --from, --force) to copy the plugin to ~/.op/plugins/local/roamresearch, set secure dir perms (700) and binary perms (755), and print next steps.
    • Makefile targets: op-plugin-test, op-plugin-build, op-plugin-install-local; root ci runs plugin tests.
    • Release archives now include both roam-cli and roamresearch; workflow builds and tars both together.
    • Docs: README adds two paths (Path A: op run with env vars; Path B: shell plugin), a manual wrapper option, and a new “configuration” help topic shown in CLI help.
  • Migration

    • Prereqs: Install 1Password CLI (op).
    • Steps: roam-cli onepassword installop plugin init roam-clisource ~/.config/op/plugins.sh → run roam-cli.
    • Dev: make op-plugin-build then roam-cli onepassword install --from ./bin/roamresearch --force.

Written for commit 8a780fe. Summary will update on new commits.

Review in cubic

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

5 issues found across 18 files

Reply with feedback, questions, or to request a fix.

Re-trigger cubic

Comment thread contrib/1password-plugin/go.mod Outdated
Comment thread contrib/1password-plugin/executable.go
Comment thread internal/cmd/onepassword_test.go Outdated
Comment thread internal/cmd/onepassword.go Outdated
Comment thread internal/cmd/onepassword.go
@Leechael
Leechael merged commit 4516c55 into main Jun 18, 2026
3 checks passed
@Leechael
Leechael deleted the feat/1password-shell-plugin branch June 18, 2026 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant