feat: add local 1Password shell plugin support - #14
Merged
Conversation
There was a problem hiding this comment.
5 issues found across 18 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
roam-cli onepassword installto copy the local plugin binaryTest Results
make cipassedmake op-plugin-buildpassedprek run --all-filespassedTest Coverage
Review Findings
Test Plan
Summary by cubic
Adds local 1Password shell plugin support for
roam-cliso users can auto-inject credentials viaopwithout managing.envfiles. Includes a new install command, plugin module, tests, docs (with env-var and shell plugin paths), and release bundling of both binaries.New Features
contrib/1password-plugin(buildsroamresearch) with credential mapping and executable schema; ignores help/version/completion for auth.roam-cli onepassword install(flags:--from,--force) to copy the plugin to~/.op/plugins/local/roamresearch, set secure dir perms (700) and binary perms (755), and print next steps.op-plugin-test,op-plugin-build,op-plugin-install-local; rootciruns plugin tests.roam-cliandroamresearch; workflow builds and tars both together.op runwith env vars; Path B: shell plugin), a manual wrapper option, and a new “configuration” help topic shown in CLI help.Migration
op).roam-cli onepassword install→op plugin init roam-cli→source ~/.config/op/plugins.sh→ runroam-cli.make op-plugin-buildthenroam-cli onepassword install --from ./bin/roamresearch --force.Written for commit 8a780fe. Summary will update on new commits.