Skip to content

fix(rtl): horizontal initialScrollIndex near the end settles on the mirror index #478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Mohamed-kassim wants to merge 2 commits into
base: main
Choose a base branch
from
+18 −4
Open

fix(rtl): horizontal initialScrollIndex near the end settles on the mirror index #478

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
405cb2c
fix(rtl): convert offset in scrollToFallbackOffset + skip unconverted…
Mohamed-kassim Jun 21, 2026
bcc3863
fix(rtl): scope initialContentOffset seed-skip to bootstrap sessions
Mohamed-kassim Jun 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/components/LegendList.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -518,7 +518,13 @@ const LegendListInner = typedForwardRef(function LegendListInner<T>(
}

const resolvedOffset = initialScroll.contentOffset ?? resolveInitialScrollOffset(ctx, initialScroll);
return usesBootstrapInitialScroll && state.initialScrollSession?.kind === "bootstrap" && Platform.OS === "web"
// For horizontal RTL, this seed is a logical (LTR) offset; feeding it to the
// native `contentOffset` unconverted lands on the RTL mirror. Skip the seed
// and let the initial-scroll dispatch (which converts) position the list.
return (usesBootstrapInitialScroll &&
state.initialScrollSession?.kind === "bootstrap" &&
Platform.OS === "web") ||
isHorizontalRTLProps({ horizontal, rtl })
? undefined
Comment thread
Mohamed-kassim marked this conversation as resolved.
Outdated
: resolvedOffset;
}, [usesBootstrapInitialScroll]);
Expand Down
13 changes: 10 additions & 3 deletions src/core/checkFinishedScroll.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import { initialScrollCompletion, initialScrollWatchdog } from "@/core/initialSc
import { Platform } from "@/platform/Platform";
import { getContentSize } from "@/state/getContentSize";
import type { StateContext } from "@/state/state";
import { toNativeHorizontalOffset } from "@/utils/rtl";

type ActiveScrollTarget = NonNullable<StateContext["state"]["scrollingTo"]>;
const INITIAL_SCROLL_MAX_FALLBACK_CHECKS = 20;
Expand Down Expand Up @@ -151,10 +152,16 @@ function checkFinishedScrollFrame(ctx: StateContext) {
}

function scrollToFallbackOffset(ctx: StateContext, offset: number) {
ctx.state.refScroller.current?.scrollTo({
const state = ctx.state;
const isHorizontal = !!state.props.horizontal;
// `offset` is a logical (LTR) offset. The normal dispatch path converts it to
// the native RTL coordinate; do the same here so the watchdog/retry doesn't
// dispatch an unconverted offset and land on the RTL mirror index.
const x = isHorizontal ? toNativeHorizontalOffset(state, offset, getContentSize(ctx)) : 0;
state.refScroller.current?.scrollTo({
animated: false,
x: ctx.state.props.horizontal ? offset : 0,
y: ctx.state.props.horizontal ? 0 : offset,
x,
y: isHorizontal ? 0 : offset,
});
}

Expand Down