-
-
Notifications
You must be signed in to change notification settings - Fork 951
Track additional statistics #6390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from 6 commits
e3fb78e
50eb70c
887ca0a
da3ad08
5e53821
db548ee
8a657e0
e1042e4
1b148a5
8cc4aaf
57a74e0
7e2fff7
a4b6b7a
bc9679e
c5c19a8
4811a93
053191e
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| -- This file should undo anything in `up.sql` | ||
| ALTER TABLE local_site | ||
| DROP COLUMN linked_instances; | ||
|
|
||
| ALTER TABLE local_site | ||
| DROP COLUMN total_posts; | ||
|
|
||
| ALTER TABLE local_site | ||
| DROP COLUMN total_comments; | ||
|
|
||
| ALTER TABLE local_site | ||
| DROP COLUMN total_users; | ||
|
|
||
| ALTER TABLE local_site | ||
| DROP COLUMN total_communities; | ||
|
|
||
| ALTER TABLE local_site | ||
| DROP COLUMN user_retention_percent; | ||
|
|
||
| ALTER TABLE local_site | ||
| DROP COLUMN local_post_english_percent; | ||
|
|
||
| ALTER TABLE local_site | ||
| DROP COLUMN ban_rate; | ||
|
|
||
| ALTER TABLE local_site | ||
| DROP COLUMN accepted_signups_rate; | ||
|
|
||
| ALTER TABLE local_site | ||
| DROP COLUMN failed_signups_rate; | ||
|
|
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| -- Your SQL goes here | ||
| ALTER TABLE local_site | ||
| ADD COLUMN linked_instances integer; | ||
|
|
||
| ALTER TABLE local_site | ||
| ADD COLUMN total_posts integer; | ||
|
|
||
| ALTER TABLE local_site | ||
| ADD COLUMN total_comments integer; | ||
|
malsadev marked this conversation as resolved.
Outdated
|
||
|
|
||
| ALTER TABLE local_site | ||
| ADD COLUMN total_users integer; | ||
|
|
||
| ALTER TABLE local_site | ||
| ADD COLUMN total_communities integer; | ||
|
|
||
| ALTER TABLE local_site | ||
| ADD COLUMN user_retention_percent integer; | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. All the percentages/rates should probably be floats. |
||
|
|
||
| ALTER TABLE local_site | ||
| ADD COLUMN local_post_english_percent integer; | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Not sure how useful this metric would be. I spose it could be useful for servers who are multi-lingual, and wanting to try to get rid of english usage.
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yeah it shouldnt be limited to a single language, but have usage percentage for every language. Maybe with a new column
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I added {
"en" : "30.10",
"und": "10.00",
"de": "59.90"
}
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm not a fan of slamming json into sql, we really should try to avoid that. Either add a new table, or better yet just remove this.
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Best put it in the existing |
||
|
|
||
| ALTER TABLE local_site | ||
| ADD COLUMN ban_rate integer; | ||
|
|
||
| ALTER TABLE local_site | ||
| ADD COLUMN accepted_signups_rate integer; | ||
|
|
||
| ALTER TABLE local_site | ||
| ADD COLUMN failed_signups_rate integer; | ||
|
malsadev marked this conversation as resolved.
Outdated
|
||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a method
FederatedInstanceView::count, then you can reuseFederatedInstanceView::joinsinstead of writing the same thing again.