qtvcp: move return out of finally in SAVE_PROGRAM#4171
Merged
Conversation
return npath sat inside the finally block, which silently overrode the except branch's return None. SAVE_PROGRAM therefore returned a valid looking path even when the write failed, swallowing the exception. Dedenting it to the method body restores the intended error semantics and clears the SyntaxWarning Python 3.14 emits for return in finally. Fixes LinuxCNC#4169.
Contributor
Author
Contributor
|
This is a clear-cut bug. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
return npathsat inside thefinallyblock, which silently overrode theexceptbranch'sreturn None. SAVE_PROGRAM returned a valid looking path even when the write failed, swallowing the exception. Dedenting it to the method body restores the intended error semantics and clears the SyntaxWarning Python 3.14 emits forreturninfinally.Fixes #4169. Same approach as #4075.