perf(components): use Streamdown static mode for finished markdown by slashdevcorpse · Pull Request #494 · LodyAI/Lody

slashdevcorpse · 2026-09-08T03:06:35Z

Related issue

Problem / pressure

Finished chat turns still render Streamdown with mode="streaming". That path runs remend and block splitting on content that will not grow, which is on the first-visit markdown path for session switch.

Summary

MarkdownRenderer selects Streamdown static when isStreaming is false and streaming while a turn is growing. isAnimating is unchanged. Does not add a publish-interval cap or change Shiki caching.

Before / after

Before	After
Finished and streaming turns both use `mode="streaming"`.	Finished turns use `mode="static"`. Growing turns stay `streaming`.

Test plan

pnpm --filter @lody/components exec vitest run tests/markdown-streamdown-mode.test.ts — 2 passed.
Full MarkdownRenderer jsdom suite not rerun here: worktree lacks ACP extension submodules (acp-extension-dsh/capabilities).
No live desktop session-switch trace.

Context handoff

Instructions for reviewing agents

Review focus: resolveMarkdownStreamdownMode and its use as Streamdown mode in markdown-renderer.tsx.
Decisions to challenge: Extracting a one-line helper so the unit test does not import MarkdownRenderer. Leaving Shiki prefix caching and the rAF publish floor to later [Feature Request] Reduce streaming-time renderer energy: per-frame full-message markdown re-parse and Shiki re-highlight #421 slices.
Plausible failures / evidence gaps: Streamdown static mode could skip a repair that finished turns currently rely on. No mounted-renderer or session-switch measurement in this PR.

Authoring context

User goal / directives: Land the small finished-turn Streamdown static-mode slice of [Feature Request] Reduce streaming-time renderer energy: per-frame full-message markdown re-parse and Shiki re-highlight #421 without duplicating perf(components): stage mobile background sync so the app stays usable #317.
Constraints / non-goals: Do not close [Feature Request] Reduce streaming-time renderer energy: per-frame full-message markdown re-parse and Shiki re-highlight #421. Do not change rAF coalescing or Shiki LRU. Do not retouch landing picker or eager-sync.
Risk-bearing decisions: Finished markdown may render without remend. Growing turns still use streaming mode.
Destructive or irreversible behavior: None.
Deliberately not done or tested: Live session-switch INP. Full markdown-streaming-reparse suite (submodule graph).
Unknowns / confidence: High that the prop is wired. Medium that static mode is a visual no-op for every finished message shape.

Finished turns no longer run the streaming remend path. Growing turns keep mode streaming. Model: grok-4.6

Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9eb160757e

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

The invariant now matches isStreaming: static for frozen markdown, streaming while a turn is growing. Word-level animated stays off. Model: grok-4.6

Interrupted finished turns with an open fence stay in streaming mode. Complete finished markdown still uses static mode. Model: grok-4.6

Model: grok-4.6

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a2da32471c

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Interrupted finished turns with indented or tilde fences stay in streaming mode so remend still runs. Closing fence length and 4-space indents follow CommonMark. Model: grok-4.6

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d98de526f9

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Interrupted finished turns with blockquote or list-nested fences stay in streaming mode. Open-fence detection uses the existing CommonMark scanner. Model: grok-4.6

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 59dcfd3c07

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-09-08T04:04:05Z

+  isStreaming: boolean,
+  text = ''
+): 'static' | 'streaming' {
+  if (isStreaming || markdownHasUnclosedFence(text)) return 'streaming';


Track list context across continuation lines

When a cancelled response opens a fence on a continuation line of an existing list, such as 1. explanation\n ```ts\nconst x = 1, markdownFenceAt sees four leading spaces without knowing they include the list-item indent and returns no fence. This makes the new resolver choose static mode and skip incomplete-Markdown repair even though the fence remains open. This is fresh evidence beyond the prior container-prefix comment: direct-marker forms are now handled, but ordinary continuation-line forms are still missed. Preserve list-container state while scanning.

AGENTS.md reference: packages/components/src/components/ai-gui/AGENTS.md:L96-L96

Useful? React with 👍 / 👎.

Leaving this. Open-fence detection now uses the same per-line CommonMark scanner as normalizeTexMathDelimiters. Same-line list/blockquote markers (10. ```tex, > ```tex) and 0–3 space continuation fences already stay on Streamdown streaming. A 4-space continuation after 1. explanation is an indented code block at document scope unless we carry list indent across lines. That is a full list parser, not this #421 slice. Interrupted mid-list continuation fences are an accepted freeze-path edge case (.github/codex-review.md).

github-actions · 2026-09-09T08:23:45Z

@slashdevcorpse, this pull request needs updates before review.

It is marked status:needs-pr-attention. Address the findings below by 2026-09-16 08:23:42 UTC. The label and this comment are removed automatically after the PR passes validation.

If the PR remains invalid for 7 days, it will be closed and marked status:pr-policy-expired. Continue afterward by opening a new pull request with the current template.

Policy findings

PR does not meet Lody contribution requirements:

- Missing required heading: ## Visual explanation
- Context handoff must include ### Original user prompt.

See `CONTRIBUTING.md` and `.github/PULL_REQUEST_TEMPLATE.md`.

perf(components): use Streamdown static mode for finished markdown

9eb1607

Finished turns no longer run the streaming remend path. Growing turns keep mode streaming. Model: grok-4.6

github-actions Bot added the scope: components label Sep 8, 2026

slashdevcorpse marked this pull request as ready for review September 8, 2026 03:21

Copilot AI lite review requested due to automatic review settings September 8, 2026 03:21

Copilot AI reviewed Sep 8, 2026

chatgpt-codex-connector Bot reviewed Sep 8, 2026

View reviewed changes

Comment thread packages/components/src/components/ai-gui/markdown-renderer.tsx Outdated

slashdevcorpse added 3 commits September 7, 2026 23:38

docs(components): align Streamdown mode contract with finished static

2c1bc7e

The invariant now matches isStreaming: static for frozen markdown, streaming while a turn is growing. Word-level animated stays off. Model: grok-4.6

fix(components): keep Streamdown remend on unclosed fences

7e561eb

Interrupted finished turns with an open fence stay in streaming mode. Complete finished markdown still uses static mode. Model: grok-4.6

docs(components): note Streamdown streaming for open fences

a2da324

Model: grok-4.6

chatgpt-codex-connector Bot reviewed Sep 8, 2026

View reviewed changes

Comment thread packages/components/src/components/ai-gui/markdown-streamdown-mode.ts Outdated

fix(components): detect CommonMark open fences for Streamdown mode

d98de52

Interrupted finished turns with indented or tilde fences stay in streaming mode so remend still runs. Closing fence length and 4-space indents follow CommonMark. Model: grok-4.6

chatgpt-codex-connector Bot reviewed Sep 8, 2026

View reviewed changes

Comment thread packages/components/src/components/ai-gui/markdown-streamdown-mode.ts Outdated

fix(components): reuse container fence scan for Streamdown mode

59dcfd3

Interrupted finished turns with blockquote or list-nested fences stay in streaming mode. Open-fence detection uses the existing CommonMark scanner. Model: grok-4.6

chatgpt-codex-connector Bot reviewed Sep 8, 2026

View reviewed changes

github-actions Bot added the status:needs-pr-attention External PR needs contributor attention before review label Sep 9, 2026

Navigation Menu

Uh oh!

perf(components): use Streamdown static mode for finished markdown - #494

perf(components): use Streamdown static mode for finished markdown#494
slashdevcorpse wants to merge 6 commits into
LodyAI:mainfrom
slashdevcorpse:perf/streamdown-static-mode

slashdevcorpse commented Sep 8, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

chatgpt-codex-connector Bot Sep 8, 2026

Uh oh!

slashdevcorpse Sep 8, 2026

Uh oh!

github-actions Bot commented Sep 9, 2026 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

slashdevcorpse commented Sep 8, 2026

Related issue

Problem / pressure

Summary

Before / after

Test plan

Context handoff

Instructions for reviewing agents

Authoring context

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Sep 8, 2026

Choose a reason for hiding this comment

Uh oh!

slashdevcorpse Sep 8, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Sep 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

github-actions Bot commented Sep 9, 2026 •

edited

Loading