fix: settle context compaction after provider stops - #573
Merged
Conversation
Treat unresolved context compaction activity as failed once its owning assistant turn finishes, so both transcript and usage footer stop spinning. Model: gpt-5.6-sol
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Record the implementation PR in both Agent Note translations. Model: gpt-5.6-sol
Add lifecycle regression coverage across finalization, persisted history reload, late completion, and a subsequent compaction turn. Model: gpt-5.6-sol
Persist failed compaction state only when the ACP prompt returns an error or the provider disconnects. Keep interrupted turns active until provider state converges. Model: gpt-5.6-sol
wibus-wee
changed the title
Model: gpt-5.6-sol
Model: gpt-5.6-sol
wibus-wee
changed the title
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
completedupdate for the sametoolCallIdFixes #570
Fixes #267
Completes the context-compaction state convergence needed by #267 after #571 fixed provider ownership.
Testing
pnpm check(Node 22.23.2)pnpm formatpnpm run docs checkNo local E2E or Model API Simulator run was added.