fix: keep fork actions visible while loading - #578
Merged
Conversation
Model: gpt-5
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue
Internal same-repository contribution; no Issue created solely for intake.
Problem / pressure
On desktop, assistant-turn actions are normally revealed by hover or keyboard focus. Starting a conversation fork replaces the Fork icon with a loading spinner, but moving the pointer away hid the entire action row and removed the visible progress signal.
Summary
Visual explanation
Simple change: one existing visibility condition now also accepts the already-propagated fork loading flag; a diagram would not add review value.
Before / after
Test plan
PATH=/opt/homebrew/opt/node@22/bin:$PATH pnpm check(all component and CLI suites passed; the Electron suite passed after restoring its locally missing binary)PATH=/opt/homebrew/opt/node@22/bin:$PATH pnpm --filter @lody/electron testPATH=/opt/homebrew/opt/node@22/bin:$PATH pnpm exec vitest run tests/assistant-turn-action-inset.test.tsfrompackages/componentsPATH=/opt/homebrew/opt/node@22/bin:$PATH pnpm --filter @lody/components typecheckpnpm run docs checkContext handoff
Instructions for reviewing agents
AssistantTurnFootervisibility classes and the desktop pending-fork regression test.Authoring context
isForkingstate at the footer visibility boundary without changing fork lifecycle or protocol code.