feat: add stable workspace switch slots - #585
Closed
wibus-wee wants to merge 2 commits into
Closed
Conversation
Model: gpt-5
Model: gpt-5
Member
Author
|
The design does not align with the expected UX direction; closing this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue
Refs #288
Problem / pressure
Workspace switching was duplicated across sidebar, mobile, and organization selectors, while numeric shortcuts need stable targets that do not change when the organization catalog reorders. The shortcut lifecycle from #572 provides one command registration path, but there was no shared workspace transition boundary or durable 1-9 slot model.
Summary
useWorkspaceSwitcher, then register Electron-onlyMod+1..9commands through the existinguseCommandlifecycle and conflict index.Visual explanation
Before / after
Mod+1..9through the unified command registry.Test plan
pnpm checkpnpm formatpnpm run docs checkpnpm e2e:checkpnpm e2e:buildpnpm e2e:smoke(4 P0 scenarios, 28 steps, including both Electron renderers)Context handoff
Instructions for reviewing agents
app-commands.tsx, anduseWorkspaceSwitcherstate transition as the risk-bearing paths.Authoring context
Original user prompt
Show original prompt