Skip to content

fix(photo): scroll PDF pages instead of changing photo - #4898

Merged
ildyria merged 3 commits into
masterfrom
fix-scroll-pdf
Oct 17, 2026
Merged

ildyria merged 3 commits into
masterfrom
fix-scroll-pdf

Conversation

@ildyria

@ildyria ildyria commented Oct 17, 2026 •

Copy link
Copy Markdown
Member

The mouse wheel no longer navigates photos while a PDF is displayed. The dock is hidden for PDFs and its move and delete actions are shown in the photo header instead.

Summary by CodeRabbit

  • New Features
    • In PDF view, mouse-wheel scrolling moves through PDF pages instead of changing photos. Arrow keys and swipe navigation remain available.
    • The dock is hidden in PDF view. When the photo is editable, delete appears in the header; move appears when the album allows moving content.
  • Bug Fixes
    • Pressing Escape closes the photo-edit modal without closing the photo. Pressing Escape again leaves the photo.

The mouse wheel no longer navigates photos while a PDF is displayed. The dock is hidden for PDFs and its move and delete actions are shown in the photo header instead.

Spec impact: Feature 097 PDF Photo View spec, plan, tasks and open questions Q-097-01 to Q-097-03 resolved, roadmap row 097.

Claude-Session: https://claude.ai/code/session_016n9EqCvZpHhBgMtkcFiD3o
The photo edit modal was not dismissible, so Escape left it open. It now closes like the album edit modal and the photo stays open. The PDF photo view feature is renumbered from 097 to 099 because 097 is taken by Tag Albums Category.

Spec impact: Feature 099 PDF Photo View adds FR-099-04, S-099-06 and T-099-04, and the feature folder, IDs and roadmap row move from 097 to 099.

Claude-Session: https://claude.ai/code/session_016n9EqCvZpHhBgMtkcFiD3o
@ildyria
ildyria requested a review from a team as a code owner October 17, 2026 20:04
@coderabbitai

coderabbitai Bot commented Oct 17, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 62f5776e-685b-4d0f-88af-7a4249571a71
📥 Commits

Reviewing files that changed from the base of the PR and between 56ebd5a and 19b2e4e.

📒 Files selected for processing: 1
  • docs/specs/4-architecture/roadmap.md
🚧 Files skipped from review as they are similar to previous changes: 1
  • docs/specs/4-architecture/roadmap.md

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 7 remain after this review.

📝 Walkthrough

Feature 099 documents and implements PDF-specific photo viewing behavior in the v8 frontend. PDF wheel events no longer navigate photos, the dock is hidden, and eligible move and delete actions appear in the photo header. The photo-edit modal uses default dismissal behavior.

Changes: PDF Photo View

Layer / File(s) Summary
Feature specification and tracking
docs/specs/4-architecture/features/099-pdf-photo-view/*, docs/specs/4-architecture/roadmap.md
The specification, open questions, plan, and task checklist record PDF viewing requirements and their status. The roadmap lists Feature 099 as Testing.
PDF navigation and dock behavior
resources/js/v8/components/gallery/photoModule/PhotoPanel.vue, resources/js/v8/components/gallery/photoModule/Dock.vue
PhotoPanel hides the dock for PDFs and does not navigate photos on wheel events in PDF view mode. Dock no longer accepts isNarrowMenu and always uses sm:h-1/4.
PDF header actions and edit dismissal
resources/js/v8/components/headers/PhotoHeader.vue, resources/js/v8/components/gallery/photoModule/PhotoPanel.vue, resources/js/v8/components/drawers/PhotoEdit.vue
PhotoHeader emits move and delete events for eligible PDFs, and PhotoPanel forwards those events. PhotoEdit no longer explicitly disables modal dismissal.

Priority: ➖ Normal

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: 🔵 Low · up to 19b2e

The roadmap update is consistent with the task checklist, but the feature records still disagree about whether PDF scenarios were manually checked. Clarify their verification status before relying on it.

Pre-merge checks: Passed 1
Check name Status Explanation
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

A rabbit turns a PDF page,
While wheel events stay in their place.
The dock steps out of view,
Move and delete appear anew.
Escape can close the edit pane,
Then leave the photo on the screen.

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2


ℹ️ Review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: e083729a-4f8c-4873-a9db-8f3797b167f9
📥 Commits

Reviewing files that changed from the base of the PR and between 318faee and 56ebd5a.

📒 Files selected for processing: 9
  • docs/specs/4-architecture/features/099-pdf-photo-view/open-questions.md
  • docs/specs/4-architecture/features/099-pdf-photo-view/plan.md
  • docs/specs/4-architecture/features/099-pdf-photo-view/spec.md
  • docs/specs/4-architecture/features/099-pdf-photo-view/tasks.md
  • docs/specs/4-architecture/roadmap.md
  • resources/js/v8/components/drawers/PhotoEdit.vue
  • resources/js/v8/components/gallery/photoModule/Dock.vue
  • resources/js/v8/components/gallery/photoModule/PhotoPanel.vue
  • resources/js/v8/components/headers/PhotoHeader.vue

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 4 remain after this review.

Comment thread docs/specs/4-architecture/features/099-pdf-photo-view/spec.md
Comment thread resources/js/v8/components/gallery/photoModule/PhotoPanel.vue
@ildyria
ildyria merged commit f4a3197 into master Oct 17, 2026
25 checks passed
@ildyria
ildyria deleted the fix-scroll-pdf branch October 17, 2026 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant