Repository navigation
Make caching on client side optional - #4940
Conversation
|
No actionable comments were generated in the recent review.
|
| Layer / File(s) | Summary |
|---|---|
Expose the client-cache setting .env.example, config/features.php, app/View/Components/Meta.php, resources/views/components/meta.blade.php, tests/Feature_v3/ClientCache/ClientCacheMetaTest.php |
The feature flag defaults to enabled and is exposed through a meta tag. Feature tests check the tag when the flag is enabled and disabled. |
Configure frontend caching resources/js/config/client-cache.ts, resources/js/config/axios-config.ts, resources/js/config/client-cache.test.ts, resources/js/app.ts, resources/js/app-v8.ts |
The frontend reads the meta tag and configures the Axios cache interceptor. When caching is disabled, it adds no-cache request headers. Both app entry points now initialize Axios before mounting the app. Tests cover setting parsing and cache behavior. |
Preserve thumbnail caching resources/js/services/thumb-asset-service.ts, resources/js/services/thumb-asset-service.test.ts |
Thumbnail requests explicitly enable Axios caching. A test checks the cache option on thumbnail requests. |
Estimated code review effort: 3 (Moderate) | ~20 minutes
Merge Risk: 
Low · up to 59ead
-
The feature test fails when client caching is disabled through the environment. Make the test independent of that override before merging, or accept the bounded test-suite failure.
Pre-merge checks: 
1
-
Failed checks: 1 warningFull details: Docstring Coverage
-
Explanation
Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 4 functions across 11 files.
Resolution
Write docstrings for the functions missing them to satisfy the coverage threshold.
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
A rabbit reads the cache setting with care
A meta tag carries the choice through the air
Axios follows the setting it sees
Thumbnails keep caching, steady as trees
Before the app mounts, setup is done
The rabbit hops off beneath the sun
There was a problem hiding this comment.
Actionable comments posted: 2

Review info
-
Run configuration-
- Source mode: Auto
- Repository: Unavailable
- Branch: Unavailable
- File: No configuration file from this repository applied
- Commit: Unavailable
- Layers: Organization UI
- Review profile: CHILL
- Plan: Advanced
- Run ID:
6062224d-b666-456e-9af6-d9d5841b2794
Files selected for processing: 10-
.env.exampleapp/View/Components/Meta.phpconfig/features.phpresources/js/config/axios-config.tsresources/js/config/client-cache.test.tsresources/js/config/client-cache.tsresources/js/services/thumb-asset-service.test.tsresources/js/services/thumb-asset-service.tsresources/views/components/meta.blade.phptests/Feature_v3/ClientCache/ClientCacheMetaTest.php
Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 7 remain after this review.
-
Codecov Report✅ All modified and coverable lines are covered by tests. 🚀 New features to boost your workflow:
|
Summary by CodeRabbit