Updated SCMAlgebras package#4433
Open
ErnestoLax wants to merge 4 commits into
Open
Conversation
d-torrance
requested changes
Jun 10, 2026
d-torrance
left a comment
Member
There was a problem hiding this comment.
Thanks for the PR!
There are a couple typos:
M2/Macaulay2/packages/SCMAlgebras.m2:57: datas ==> data
M2/Macaulay2/packages/SCMAlgebras.m2:274: informations ==> information
Contributor
Author
|
Thank you for your response, I corrected them |
d-torrance
requested changes
Jun 11, 2026
Co-authored-by: Doug Torrance <douglas.a.torrance@gmail.com>
Contributor
Author
|
Thanks for pointing out this new feature of version 1.26.06. I fixed the code according to your suggestion |
Contributor
Author
|
Commited small changes in documentation and adding of example for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SCMAlgebras package updated to newly released version 1.2
Changelog
Bug fixes: Fixed a small bug in
isSCMfunction leading to some unexpected errorsNew types and functions:
PrimaryDataListto store and parse the datas of the primary decomposition of an idealgetPrimaryDatato construct aPrimaryDataList, which is basically a list containing all pairsfilterIdealfunction to skip the computation of the primary decomposition, by using the information stored in the PrimaryDataList.Notes: All the additions to the package are documented and tests were added for the newly introduced functions. A general refactor of the existing functions, in order to optimize computation times was performed