Skip to content

Updated SCMAlgebras package#4433

Open
ErnestoLax wants to merge 4 commits into
Macaulay2:developmentfrom
ErnestoLax:development
Open

Updated SCMAlgebras package#4433
ErnestoLax wants to merge 4 commits into
Macaulay2:developmentfrom
ErnestoLax:development

Conversation

@ErnestoLax

Copy link
Copy Markdown
Contributor

SCMAlgebras package updated to newly released version 1.2

Changelog

Bug fixes: Fixed a small bug in isSCM function leading to some unexpected errors

New types and functions:

  • Added new type PrimaryDataList to store and parse the datas of the primary decomposition of an ideal $I$.
  • Added function getPrimaryData to construct a PrimaryDataList, which is basically a list containing all pairs ${Q,\dim \sqrt{Q}}$ where $Q$ is a primary component of $I$.
  • Added optional argument PrimaryDataList to filterIdeal function to skip the computation of the primary decomposition, by using the information stored in the PrimaryDataList.

Notes: All the additions to the package are documented and tests were added for the newly introduced functions. A general refactor of the existing functions, in order to optimize computation times was performed

@d-torrance d-torrance left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

There are a couple typos:

M2/Macaulay2/packages/SCMAlgebras.m2:57: datas ==> data
M2/Macaulay2/packages/SCMAlgebras.m2:274: informations ==> information

@ErnestoLax

Copy link
Copy Markdown
Contributor Author

Thank you for your response, I corrected them

Comment thread M2/Macaulay2/packages/SCMAlgebras.m2 Outdated
Co-authored-by: Doug Torrance <douglas.a.torrance@gmail.com>
@ErnestoLax

Copy link
Copy Markdown
Contributor Author

Thanks for pointing out this new feature of version 1.26.06.

I fixed the code according to your suggestion

@ErnestoLax

Copy link
Copy Markdown
Contributor Author

Commited small changes in documentation and adding of example for getPrimaryData function

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants