Skip to content

Adding documentation and cleaning up arings #4441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
MichaelABurr wants to merge 12 commits into
base: development
Choose a base branch
from
Draft

Adding documentation and cleaning up arings #4441

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
8aa87ff
Use templates for get_from_BigReal
d-torrance Jun 12, 2026
17236b4
Use templates for get_from_double
d-torrance Jun 12, 2026
4167958
Use templates for get_from_BigComplex
d-torrance Jun 12, 2026
6308802
Use templates for get_from_complex_double
d-torrance Jun 12, 2026
e20c140
Use templates for get_from_Interval
d-torrance Jun 12, 2026
74ba32c
Use templates for get_from_ComplexInterval
d-torrance Jun 12, 2026
6eea017
Use a single template for mylift(_, ARingRRi)
d-torrance Jun 12, 2026
9cbce55
Merge pull request #59 from d-torrance/aring-template
MichaelABurr Jun 12, 2026
80f438a
Update tests that work since we can map RR -> QQ now
d-torrance Jun 13, 2026
9f2c92a
Use a template for mypromote(ARingQQ, _)
d-torrance Jun 16, 2026
4c55d28
Use a template for same-type mypromote
d-torrance Jun 16, 2026
f93b8ea
Merge pull request #60 from d-torrance/aring-template
MichaelABurr Jun 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions M2/Macaulay2/e/basic-rings/aring-GF-flint-big.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,13 +226,6 @@ class ARingGFFlintBig : public RingInterface
return true;
}

bool set_from_BigReal(ElementType& result, gmp_RR a) const
{
(void) result;
(void) a;
return false;
}

void negate(ElementType& result, const ElementType& a) const
{
fq_nmod_neg(&result, &a, mContext);
Expand Down
7 changes: 0 additions & 7 deletions M2/Macaulay2/e/basic-rings/aring-GF-flint.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,13 +207,6 @@ class ARingGFFlint : public RingInterface
return true;
}

bool set_from_BigReal(ElementType& result, gmp_RR a) const
{
(void) result;
(void) a;
return false;
}

void negate(ElementType& result, const ElementType& a) const
{
fq_zech_neg(&result, &a, mContext);
Expand Down
7 changes: 0 additions & 7 deletions M2/Macaulay2/e/basic-rings/aring-QQ-flint.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,13 +116,6 @@ class ARingQQFlint : public SimpleARing<ARingQQFlint>
return true;
}

bool set_from_BigReal(ElementType& result, gmp_RR a) const
{
(void) result;
(void) a;
return false;
}

void set_var(ElementType& result, int v) const
{
(void) v;
Expand Down
7 changes: 0 additions & 7 deletions M2/Macaulay2/e/basic-rings/aring-ZZ-flint.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,13 +111,6 @@ void set_from_mpz(ElementType& result, mpz_srcptr a) const
return false;
}

bool set_from_BigReal(ElementType& result, gmp_RR a) const
{
(void) result;
(void) a;
return false;
}

void set_var(ElementType& result, int v) const
{
(void) v;
Expand Down
7 changes: 0 additions & 7 deletions M2/Macaulay2/e/basic-rings/aring-ZZp-ffpack.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,13 +160,6 @@ class ARingZZpFFPACK : public SimpleARing<ARingZZpFFPACK>

bool set_from_mpq(ElementType &result, mpq_srcptr a) const;

bool set_from_BigReal(ElementType &result, gmp_RR a) const
{
(void) result;
(void) a;
return false;
}

ElementType computeGenerator() const;

void set_var(ElementType &result, int v) const
Expand Down
7 changes: 0 additions & 7 deletions M2/Macaulay2/e/basic-rings/aring-ZZp-flint.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,13 +119,6 @@ class ARingZZpFlint : public SimpleARing<ARingZZpFlint>
return true;
}

bool set_from_BigReal(ElementType &result, gmp_RR a) const
{
(void) result;
(void) a;
return false;
}

// arithmetic
void negate(ElementType &result, ElementType a) const
{
Expand Down
7 changes: 0 additions & 7 deletions M2/Macaulay2/e/basic-rings/aring-ZZp.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,13 +141,6 @@ class ARingZZp : public SimpleARing<ARingZZp>
return true;
}

bool set_from_BigReal(elem &result, gmp_RR a) const
{
(void) result;
(void) a;
return false;
}

// arithmetic
void negate(elem &result, elem a) const
{
Expand Down
7 changes: 0 additions & 7 deletions M2/Macaulay2/e/basic-rings/aring-m2-GF.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,13 +186,6 @@ class ARingGFM2 : public SimpleARing<ARingGFM2>
return true;
}

bool set_from_BigReal(elem &result, gmp_RR a) const
{
(void) result;
(void) a;
return false;
}

void negate(elem &result, elem a) const
{
if (a != 0)
Expand Down
7 changes: 0 additions & 7 deletions M2/Macaulay2/e/basic-rings/aring-tower.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,13 +227,6 @@ class ARingTower : public RingInterface
return false;
} // TODO: write this

bool set_from_BigReal(elem &result, gmp_RR a) const
{
(void) result;
(void) a;
return false;
}

// arithmetic
void negate(elem &result, elem a) const
{
Expand Down
Loading
Loading