Skip to content

Feat madspace ramon#10

Draft
ramonpeter wants to merge 14 commits into
mainfrom
feat-madspace-ramon
Draft

Feat madspace ramon#10
ramonpeter wants to merge 14 commits into
mainfrom
feat-madspace-ramon

Conversation

@ramonpeter

@ramonpeter ramonpeter commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

Features added:

  • Cuts are directly piped to the 2->2 and 2->3 mappings to improve cutting efficiency.
  • ColorOrderedMapping is now embedded in the top-level PhaseSpaceMapping class and is being selected as t-channel strategy, taking specific color-order to build its mapping
  • Splitting of discrete and continuous random numbers. Relevant for the ColorOrderedMapping which takes a discrete index for each 2->3 mapping

@ramonpeter ramonpeter requested a review from theoheimel June 23, 2026 15:06
theoheimel
theoheimel requested changes Jun 23, 2026
View reviewed changes

@theoheimel theoheimel left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See suggested changes

Comment thread madspace/src/phasespace/phasespace.cpp Outdated
Comment thread madspace/src/phasespace/two_particle.cpp Outdated
Comment thread madspace/src/phasespace/cuts.cpp Outdated
@ramonpeter ramonpeter requested a review from theoheimel June 24, 2026 07:28
@ramonpeter ramonpeter marked this pull request as draft June 25, 2026 07:47
@ramonpeter ramonpeter marked this pull request as ready for review June 26, 2026 13:31
@Qubitol Qubitol added this to the Alpha release milestone Jul 1, 2026
@ramonpeter

ramonpeter commented Jul 1, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

test_pdf does not work anymore! probably linked to some changes I merged from main!
@theoheimel thats linked to some of your changes

@ramonpeter ramonpeter marked this pull request as draft July 1, 2026 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@theoheimel theoheimel Awaiting requested review from theoheimel

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

Alpha release

Development

Successfully merging this pull request may close these issues.

3 participants

@ramonpeter @theoheimel @Qubitol