fix(backup): don't fail backup when diff reporting fails - #39
Merged
Conversation
Diff reporting (added/altered/deleted emails, threshold warnings, monitored folders) runs after the snapshot has been created and verified. Until now a failing `restic diff` (e.g. a command timeout) raised out of _generate_diff_summary and marked the whole backup as failed, which also suppressed the change notification emails. _generate_diff_summary now also catches BackupError, so restic-level reporting failures (ResticCommandFailedError, ResticBackupFailedError, SnapshotIDNotFoundError) are logged and turned into a summary string instead of propagating. An otherwise successful backup stays successful. - add test_diff_failure_does_not_fail_backup - bump version to 0.5.2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Diff reporting (added/altered/deleted emails, threshold warnings, monitored folders) runs after the snapshot has been created and verified. Until now a failing
restic diff(e.g. a command timeout) raised out of _generate_diff_summary and marked the whole backup as failed, which also suppressed the change notification emails._generate_diff_summary now also catches BackupError, so restic-level reporting failures (ResticCommandFailedError, ResticBackupFailedError, SnapshotIDNotFoundError) are logged and turned into a summary string instead of propagating. An otherwise successful backup stays successful.