sql: fix coordinator panic parsing Unicode-numeric durations#36846
Merged
aljoscha merged 1 commit intoJun 2, 2026
Conversation
`Duration::parse` located the end of the leading number with
`chars().position(|c| \!char::is_numeric(c))`, which returns a *character*
index, and then sliced the string with it as a *byte* offset. `char::is_numeric`
also matches multi-byte Unicode numerics (e.g. '²', '½'), so for such input the
character index and byte offset diverge and the slice can land mid-character,
panicking the coordinator thread:
SET statement_timeout = '²';
SET idle_in_transaction_session_timeout = '1²ms';
Use `str::find`, which returns a byte index suitable for slicing, and restrict
the leading run to ASCII digits — exactly what the subsequent `u64::parse`
accepts. Inputs containing Unicode numerics now cleanly return a parse error
instead of panicking.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
aljoscha
changed the title
ggevay
approved these changes
Jun 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Duration::parselocated the end of the leading number withchars().position(|c| \!char::is_numeric(c)), which returns a character index, and then sliced the string with it as a byte offset.char::is_numericalso matches multi-byte Unicode numerics (e.g. '²', '½'), so for such input the character index and byte offset diverge and the slice can land mid-character, panicking the coordinator thread:Use
str::find, which returns a byte index suitable for slicing, and restrict the leading run to ASCII digits — exactly what the subsequentu64::parseaccepts. Inputs containing Unicode numerics now cleanly return a parse error instead of panicking.Fixes SQL-285