Skip to content

Ensure CMEW can be run at other sites #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Theo Geddes (mo-tgeddes) wants to merge 6 commits into
base: main
Choose a base branch
from
+8 −6
Open

Ensure CMEW can be run at other sites #65

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
c8709d7
#55: allow config file to be set through rose edit
Mar 23, 2023
71a395e
#55: clearer error messages
Mar 23, 2023
92af25e
#55: update metadat
Mar 23, 2023
c5cdaf0
#55: reformat error messages
Mar 23, 2023
cdc7a1d
#55: run rose config dump
Mar 23, 2023
fa2eccb
#55: update workflow test to pass in site
Mar 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/default.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ jobs:
eval "$(conda shell.bash hook)"
conda activate cmew
cd climate-model-evaluation-workflow
cylc validate .
cylc validate . -O metoffice

- name: Run Cylc configuration linter
run: |
Expand Down
6 changes: 4 additions & 2 deletions climate-model-evaluation-workflow/flow.cylc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,9 @@
#!jinja2
# flow.cylc
{{ assert(SITE != "", "SITE must be set to something other than an empty string") }}
{{ assert(MODULE_NAME != "", "MODULE_NAME must be set to something other than an empty string") }}
{{ assert(SITE != "", "SITE must be set to something other than an empty string.
Use -O <site> on the command line or set opts to your site through rose edit.") }}
{{ assert(MODULE_NAME != "", "MODULE_NAME must be set to something other than an empty string.
Make sure the opt config file is set through the site.") }}

[scheduler]
UTC mode = True
Expand Down
4 changes: 2 additions & 2 deletions climate-model-evaluation-workflow/meta/rose-meta.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,8 +178,8 @@ help=If required, this value must be set in a site-specific configuration file
type=quoted

[template variables=SITE]
compulsory=true
compulsory=false
description=The site at which the Rose suite will run.
help=This value must be set in a site-specific configuration file located in
=the 'opt/' directory.
values="metoffice"
values="metoffice",""
2 changes: 1 addition & 1 deletion climate-model-evaluation-workflow/rose-suite.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
opts=metoffice
opts=

[template variables]
DRS_ANA4MIPS="default"
Expand Down