2164 add dfss operator and plots#2258
Draft
James Ross (james-a-f-ross) wants to merge 18 commits into
Draft
Conversation
James Ross (james-a-f-ross)
requested review from
David Flack (daflack) and
James Frost (jfrost-mo)
Author
|
James Frost (@jfrost-mo) David Flack (@daflack) Hi both, I am not finished totally with the unit tests and there are a couple things to polish up in here. I feel like it might be good to just get another pair of eyes on a few things especially with the plotting stuff as I've needed to add a couple of my own plotting operators. |
James Ross (james-a-f-ross)
removed request for
David Flack (daflack) and
James Frost (jfrost-mo)
| values="centile", "threshold" | ||
| trigger=template variables=CENTILE: "centile"; | ||
| template variables=THRESHOLD: "threshold"; | ||
| compulsory=true |
Contributor
There was a problem hiding this comment.
Might be nice to have both this one and the centile one as a list so can put multiple options in?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution checklist
Aim to have all relevant checks ticked off before merging. See the developer's guide for more detail.