Update GitHub Actions workflows#133
Open
Yaswant Pradhan (yaswant) wants to merge 2 commits into
Open
Conversation
25 tasks
Yaswant Pradhan (yaswant)
marked this pull request as ready for review
July 17, 2026 14:51
Yaswant Pradhan (yaswant)
requested a review
from Giorgia (GiorgiaLine)
as a code owner
July 17, 2026 14:51
There was a problem hiding this comment.
Pull request overview
Updates this repository’s GitHub Actions configuration to align with MetOffice/growss#80, focusing on workflow hardening and consistency across shared/reusable workflows.
Changes:
- Add Zizmor configuration and update multiple workflows (permissions/concurrency/guards) to match the shared approach in growss.
- Pin several third-party actions in the user-guide workflow and adjust how deployment conditions are evaluated.
- Improve metadata/docs hygiene (Sphinx doc project URLs; PR template wording/formatting tweaks).
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
doc/pyproject.toml |
Adds project.urls metadata for repository/docs/discussions. |
.github/zizmor.yml |
Introduces Zizmor linter rule configuration and per-workflow ignore lists. |
.github/workflows/user-guide.yaml |
Pins key actions by SHA; tweaks deploy-condition logic and checkout configuration. |
.github/workflows/umdp3_fixer.yaml |
Adds header/permissions and switches reusable workflow ref to @develop. |
.github/workflows/trigger-project-workflow.yaml |
Adds header, narrows top-level permissions, adds repo guard, switches reusable workflow ref to @develop. |
.github/workflows/track-review-project.yaml |
Adds header/permissions, passes PAT secret explicitly, switches reusable workflow ref to @develop. |
.github/workflows/cla-check.yaml |
Adds header/concurrency hardening and switches reusable workflow ref to @develop. |
.github/workflows/check-cr-approved.yaml |
Adds header/permissions and switches reusable workflow ref to @develop. |
.github/pull_request_template.md |
Adds an “One-line summary” placeholder and fixes/normalizes checklist wording. |
Comments suppressed due to low confidence (1)
.github/workflows/check-cr-approved.yaml:20
- This job references an external reusable workflow using the mutable ref
@develop. Pinninguses:to an immutable commit SHA (or signed/release tag) is recommended to avoid unreviewed changes being pulled in at runtime.
permissions:
contents: read # Required to evaluate the event trigger metadata safely
if: ${{ github.event.pull_request.number }}
uses: MetOffice/growss/.github/workflows/check-cr-approved.yaml@develop
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+22
to
+26
| permissions: | ||
| actions: read # Required to check out code or parse files safely | ||
| contents: read # Required to read the upstream triggered workflow run artifact status | ||
| pull-requests: write # Required for the downstream engine to add comments or update metadata on the PR | ||
| uses: MetOffice/growss/.github/workflows/trigger-project-workflow.yaml@develop # zizmor: ignore[unpinned-uses] |
Comment on lines
+20
to
+24
| permissions: | ||
| actions: read # Required to check out code or parse files safely | ||
| contents: read # Required to read the upstream triggered workflow run artifact status | ||
| pull-requests: write # Required for the downstream engine to add comments or update metadata on the PR | ||
| uses: MetOffice/growss/.github/workflows/track-review-project.yaml@develop |
Comment on lines
+24
to
28
| permissions: | ||
| contents: read # Required to evaluate the event trigger metadata safely | ||
| pull-requests: write # Required for the downstream engine to post status comments on the PR | ||
| uses: MetOffice/growss/.github/workflows/cla-check.yaml@develop | ||
| with: |
Comment on lines
+16
to
+18
| permissions: | ||
| contents: read | ||
| uses: MetOffice/growss/.github/workflows/umdp3_fixer.yaml@develop |
Comment on lines
+10
to
+18
| rules: | ||
| unpinned-uses: | ||
| ignore: | ||
| - "check-cr-approved.yaml" | ||
| - "cla-check.yaml" | ||
| - "sphinx-docs.yaml" | ||
| - "track-review-project.yaml" | ||
| - "trigger-project-workflow.yaml" | ||
| - "umdp3_fixer.yaml" |
| @@ -1,5 +1,7 @@ | |||
| # PR Summary | |||
|
|
|||
| <!-- Oneline Summary --> | |||
| Github Copilot Personal, ChatGPT GPT-4, etc) and I have followed the | ||
| [Simulation Systems AI policy](https://metoffice.github.io/simulation-systems/FurtherDetails/ai.html) | ||
| (including attribution labels) | ||
| - [ ] Some of the content of this change has been produced with the assistance of _Generative AI tool name_ (e.g., Met Office Github Copilot Enterprise, Github Copilot Personal, ChatGPT GPT-4, etc) and I have followed the [Simulation Systems AI policy](https://metoffice.github.io/simulation-systems/FurtherDetails/ai.html) (including attribution labels) |
James Bruten (james-bruten-mo)
approved these changes
Jul 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Align repository actions with MetOffice/growss#80
Code Reviewer: James Bruten (@james-bruten-mo)
Code Quality Checklist
(Some checks are automatically carried out via the CI pipeline)
readability of the code
rose-meta/jules-sharedthen have you supplied a linked UM and LFRic Apps PR?Testing
stem suites
acceptable (eg. kgo changes)
tests, unit tests, etc.)
trac.log
Security Considerations
Performance Impact
performance measurements have been conducted
AI Assistance and Attribution
of Generative AI tool name (e.g., Met Office Github Copilot Enterprise,
Github Copilot Personal, ChatGPT GPT-4, etc) and I have followed the
Simulation Systems AI policy
(including attribution labels)
Documentation
confirmed that it builds correctly
Approvals
Please request all relevant approvals. See the CodeOwners.txt file for section
owners.
Technical
Scientific
Sci/Tech Review
Please alert the code reviewer via a tag when you have approved the SR
Code Review