Skip to content

fix: avoid proxy name collisions in provider uniquification - #3055

Open
olicesx wants to merge 1 commit into
MetaCubeX:Alphafrom
olicesx:fix-provider-name-collision
Open

fix: avoid proxy name collisions in provider uniquification#3055
olicesx wants to merge 1 commit into
MetaCubeX:Alphafrom
olicesx:fix-provider-name-collision

Conversation

@olicesx

@olicesx olicesx commented Aug 1, 2026

Copy link
Copy Markdown

Closes #2931

uniqueName generated name-01 without checking whether that name was already taken (e.g. by another node's own fragment), so the colliding node got dropped later during assembly. The generated name is now registered and the suffix keeps incrementing until a free slot is found.

Copilot AI review requested due to automatic review settings August 1, 2026 14:33

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes a proxy-provider URI import bug where the uniqueName suffixing logic could generate a name (e.g. name-01) that already existed, causing a later proxy to be dropped during assembly. The update ensures generated names are registered and the suffix increments until an unused slot is found.

Changes:

  • Update uniqueName to check for collisions against already-registered names and to register the generated name.
  • Add a regression test covering the reported duplicate-name + pre-existing-suffix scenario.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
common/convert/converter.go Fixes uniqueName so generated suffixed names don’t collide with pre-existing names and are registered immediately.
common/convert/converter_test.go Adds a regression test ensuring name, name-01, name-02, name-03 are all retained and uniquely assigned.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants