[Alpha] fix(wireguard): prefer mips over gVisor for outbound auto IP stack on Windows - #3112
Open
notlun1x wants to merge 2 commits into
Open
[Alpha] fix(wireguard): prefer mips over gVisor for outbound auto IP stack on Windows#3112notlun1x wants to merge 2 commits into
notlun1x wants to merge 2 commits into
Conversation
…Windows IPStackOption's "auto" mode picked ipStackGVisor whenever the binary was built with the with_gvisor tag (the default for official releases), regardless of OS. On Windows this measured roughly 3x lower WireGuard outbound upload throughput than ipStackMips on otherwise identical builds and network paths (~15 Mbps vs ~50 Mbps). mips carries no build-tag requirement and is already the fallback for non-with_gvisor builds, so prefer it on Windows unconditionally and keep the existing gVisor-if-built behavior on other platforms, where this hasn't been observed to regress throughput. Benchmark (Windows 11 x64, 50/50 Mbps WAN): - with_gvisor build + mode: auto (gvisor): 15.09 Mbps Upload - with_gvisor build + mode: mips (mips): 49.96 Mbps Upload - clean build (without with_gvisor): 48.21 Mbps Upload
fix: prefer mips over gVisor for wireguard outbound auto IP stack on …
notlun1x
changed the title
Collaborator
|
mipstack is still in the early stages of rapid development, and there remains a gap in stability and robustness compared to gVisor; consequently, we do not currently consider this the right time to set it as the default. Furthermore, we lack sufficient comparative data from other platforms to make an informed decision. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IPStackOption's "auto" mode picked ipStackGVisor whenever the binary was built with the with_gvisor tag (the default for official releases), regardless of OS. On Windows this measured roughly 3x lower WireGuard outbound upload throughput than ipStackMips on otherwise identical builds and network paths (~15 Mbps vs ~50 Mbps).
mips carries no build-tag requirement and is already the fallback for non-with_gvisor builds, so prefer it on Windows unconditionally and keep the existing gVisor-if-built behavior on other platforms, where this hasn't been observed to regress throughput.
Benchmark (Windows 11 x64, 50/50 Mbps WAN):