fix: Support SLIP44 format changes - #204
Merged
Merged
Conversation
Mrtenz
approved these changes
Jul 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The SLIP44 format changed, making our automatic update job fail, this PR adjusts the build script for it and updates the JSON file.
Note
Medium Risk
Changes affect derived BIP-44 coin-type hex values used by consumers of slip44.json; incorrect parsing or hex math could mis-route wallet derivations for affected coins.
Overview
Upstream SLIP-0044 dropped the hex column from its registry table, so the
src/build.jsgenerator no longer parses a0x…field fromslip44.md. It now reads coin type, symbol, and name, derives hardened coin type as0x80000000 | index, and skips rows with empty symbol and name.slip44.jsonis regenerated from that logic: many new coin-type entries are added, and hex values are updated where they no longer match the computed formula (e.g. Morpheum, Ice Network, Osmosis). One existing entry’s hex is normalized to lowercase (0x800010cafor Loca).Reviewed by Cursor Bugbot for commit bd99a88. Bugbot is set up for automated code reviews on this repo. Configure here.