Fix empty sort dropdown on secondary issue list views - #589
Merged
Conversation
Only IssueList, WeekList, NextWeekList, and FutureList populated sort_options/current_sort and applied the ?sort= param via apply_sort(). Every other view rendering issue_list.html (series, arc, creator, character, universe, team issue/series lists) left those unset, so their sort dropdowns rendered empty and sorting had no effect. Wire all of them up to the shared SORT_OPTIONS/apply_sort helpers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
issue_sort.html) readssort_options/current_sortfrom context, but onlyIssueList,WeekList,NextWeekList, andFutureListever set them — every other view renderingissue_list.htmlleft the dropdown empty and silently ignored the?sort=param.SORT_OPTIONS/apply_sorthelpers (fromissue_list_helpers.py) into the remaining affected views:SeriesIssueList,ArcIssueList,CreatorSeriesList,CreatorIssueList,CharacterSeriesList,CharacterIssueList,UniverseSeriesList,UniverseIssueList, andTeamIssueList.