Log client IP on signup/activation and document duplicate-account lookup - #591
Merged
Conversation
Matches the (user=, ip=) format used in api/authentication.py so log entries are easy to grep for users signing up multiple accounts from the same IP.
Cross-references signup, activation, and API auth log lines (all sharing the (user=, ip=) format) so admins can spot one IP behind multiple usernames.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_client_iphelper) alongside the username on account signup and activation, matching the(user=, ip=)format already used by the API auth logs inapi/authentication.py.journalctlcommands in DEPLOYMENT.md for admins to find IPs behind multiple usernames, cross-referencing signup, activation, and authenticated API request log lines.Motivation
Gives admins a way to spot duplicate accounts by correlating signup/activation events with API auth activity from the same IP.