Skip to content

Add AlternativeNumber element to v1.1 schema #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bpepple merged 1 commit into from
Jul 17, 2026
Merged

Add AlternativeNumber element to v1.1 schema #86

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions drafts/v1.1/MetronInfo.xsd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
<xs:element name="MangaVolume" type="xs:string" minOccurs="0" /> <!-- This is used for Manga -->
<xs:element name="CollectionTitle" type="xs:string" minOccurs="0" />
<xs:element name="Number" type="xs:string" minOccurs="0" />
<xs:element name="AlternativeNumber" type="xs:string" minOccurs="0" />
<xs:element name="Stories" type="storyType" minOccurs="0" /> <!-- Story titles in issue -->
<xs:element name="Summary" type="xs:string" minOccurs="0" />
<xs:element name="Prices" type="pricesType" minOccurs="0" />
Expand Down
38 changes: 36 additions & 2 deletions tests/test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,28 @@
'<?xml version="1.0" encoding="UTF-8"?><MetronInfo>'
"<Series><Name>Foo</Name><Volume>0</Volume></Series><Number /></MetronInfo>",
),
(
TEST_V11_XSD,
'<?xml version="1.0" encoding="UTF-8"?><MetronInfo>'
"<Series><Name>Foo</Name></Series><Number>1</Number>"
"<AlternativeNumber>1A</AlternativeNumber><PageCount>0</PageCount></MetronInfo>",
),
(
TEST_V11_XSD,
'<?xml version="1.0" encoding="UTF-8"?><MetronInfo>'
"<Series><Name>Foo</Name></Series><Number>1</Number><PageCount>0</PageCount></MetronInfo>",
),
],
ids=[
"valid_xml",
"zero_page_count",
"volume_zero",
"v11_valid_xml",
"v11_zero_page_count",
"v11_volume_zero",
"v11_alternative_number",
"v11_alternative_number_absent",
],
ids=["valid_xml", "zero_page_count", "volume_zero", "v11_valid_xml", "v11_zero_page_count", "v11_volume_zero"],
)
def test_valid(xsd: Path, xml: Path | str) -> None:
schema = XMLSchema11(xsd)
Expand Down Expand Up @@ -66,8 +86,22 @@ def test_valid(xsd: Path, xml: Path | str) -> None:
'<?xml version="1.0" encoding="UTF-8"?><MetronInfo>'
"<Series><Name>Foo</Name><Volume>-1</Volume></Series><Number /></MetronInfo>",
),
(
TEST_V11_XSD,
'<?xml version="1.0" encoding="UTF-8"?><MetronInfo>'
"<Series><Name>Foo</Name></Series><Number>1</Number>"
"<AlternativeNumber>1A</AlternativeNumber><AlternativeNumber>1B</AlternativeNumber></MetronInfo>",
),
],
ids=[
"dup_primary_attr_xml",
"negative_page_count",
"negative_volume",
"v11_dup_primary_attr_xml",
"v11_negative_page_count",
"v11_negative_volume",
"v11_duplicate_alternative_number",
],
ids=["dup_primary_attr_xml", "negative_page_count", "negative_volume", "v11_dup_primary_attr_xml", "v11_negative_page_count", "v11_negative_volume" ],
)
def test_invalid(xsd: Path, xml: Path | str) -> None:
schema = XMLSchema11(xsd)
Expand Down