top: Make top a conditional feature and disable by default on Windows#56
Closed
brgoing wants to merge 1 commit into
Closed
top: Make top a conditional feature and disable by default on Windows#56brgoing wants to merge 1 commit into
brgoing wants to merge 1 commit into
Conversation
bcapener
approved these changes
Jun 8, 2026
jimmunn
reviewed
Jun 8, 2026
Adds a 'top' configuration option that is enabled by default, and makes compilation of nvme-top code conditional on the feature enablement. Disables the top feature by default on Windows due to compatibility issues. Signed-off-by: Broc Going <bgoing@micron.com>
brgoing
force-pushed
the
bgoing/make-top-feature-optional
branch
from
745153d to
01a392c
Compare
bcapener
approved these changes
Jun 8, 2026
jimmunn
approved these changes
Jun 8, 2026
Author
|
Closing. Created upstream PR linux-nvme#3439. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a 'top' configuration option that is enabled by default, and makes compilation of nvme-top code conditional on the feature enablement. Disables the top feature by default on Windows due to compatibility issues.