Added Folia Support. - #947
Open
KeyHeld wants to merge 3 commits into
Open
Conversation
- Add FoliaUtil.isFolia() detection via RegionizedServer class check - Replace Bukkit.getScheduler() calls with Folia-safe equivalents - Add dev.folia:folia-api dependency to pom.xml (provided scope) - Add folia-supported: true to plugin.yml
|
Just a few things that caught my eye: Hardcoded API Version: The pom.xml pins folia-api to 1.20.1-R0.1-SNAPSHOT, which might cause issues since Vault needs to support multiple versions. Class Loading Check: Using Class.forName inside FoliaUtil throws a ClassNotFoundException on standard servers, which isn't ideal for performance. Scheduler Logic: The manual if (FoliaUtil.isFolia()) checks scattered around Vault.java feel a bit messy. Usually, something like FoliaLib or a cleaner wrapper makes this much easier to maintain. Might need a bit of refactoring before it's good to go. What do you think? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added Folia Support.