Accept Integrated GPUs - #10
Open
chymyaa wants to merge 2 commits into
Open
Conversation
Removed unnecessary checks for discrete GPU type when selecting the first suitable physical device.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the hard-coded filter that rejected any device that is not VK_PHYSICAL_DEVICE_TYPE_DISCRETE_GPU.
This allows integrated GPUs / APUs (such as AMD Radeon 8060S, 880M, Intel Arc, etc.) that fully support the required Vulkan features (swapchain, ray tracing pipeline, acceleration structures, etc.) to be selected.
Problem:
findPhysicalDevice() previously had:
C++if (properties.deviceType != VK_PHYSICAL_DEVICE_TYPE_DISCRETE_GPU) continue;This caused an immediate “No suitable physical device found!” crash on many modern APUs even when they supported all required extensions and features.
Changes
Removed the discrete-only device type check.
Device selection is now purely capability-based (as already implemented in isDeviceSuitable()).
Tested on
GPU: AMD Radeon 8060S (integrated)
OS: Windows
Result: Game now boots successfully in windowed mode, with text errors though.