Skip to content

GEOPY-2911: Migrate surface-apps to python 3.12#47

Open
domfournier wants to merge 6 commits into
release/GA_4.8from
GEOPY-2911
Open

GEOPY-2911: Migrate surface-apps to python 3.12#47
domfournier wants to merge 6 commits into
release/GA_4.8from
GEOPY-2911

Conversation

@domfournier

@domfournier domfournier commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

GEOPY-2911 - Migrate surface-apps to python 3.12

Copilot AI review requested due to automatic review settings June 15, 2026 16:24
@github-actions github-actions Bot changed the title GEOPY-2911 GEOPY-2911: Migrate surface-apps to python 3.12 Jun 15, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR migrates surface-apps to Python 3.12+ across packaging, documentation, CI, and conda-lock artifacts, aligning dependency pins with the newer runtime and updating related build metadata.

Changes:

  • Raise minimum supported Python version to 3.12 (and add 3.13 matrices/lockfiles) across docs, CI, and packaging metadata.
  • Update key dependency pins (e.g., numpy/scipy/pydantic/geoh5py/geoapps-utils) and refresh conda-lock outputs for 3.12/3.13.
  • Adjust build/doc tooling (recipe build env override, Sphinx version handling, ReadTheDocs python version).

Reviewed changes

Copilot reviewed 29 out of 32 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
recipe.yaml Bumps python_min to 3.12, updates dependency constraints, and refines build/test sections for the conda recipe.
README.rst Updates stated minimum Python version to 3.12+.
README-dev.rst Updates developer-facing Python version list (but still references missing tooling; see comments).
pyproject.toml Raises requires-python to >=3.12 and updates dependency constraints and tool config (ruff target).
package.rst Updates stated minimum Python version to 3.12+.
install.bat Updates default Python version used by the installer to 3.12.
environments/py-3.13-win-64.conda.lock.yml Adds new conda-lock output for Python 3.13 on Windows runtime env.
environments/py-3.13-win-64-dev.conda.lock.yml Adds new conda-lock output for Python 3.13 on Windows dev env.
environments/py-3.13-linux-64.conda.lock.yml Adds new conda-lock output for Python 3.13 on Linux runtime env.
environments/py-3.13-linux-64-dev.conda.lock.yml Adds new conda-lock output for Python 3.13 on Linux dev env.
environments/py-3.12-win-64.conda.lock.yml Refreshes conda-lock output for Python 3.12 on Windows runtime env.
environments/py-3.12-win-64-dev.conda.lock.yml Refreshes conda-lock output for Python 3.12 on Windows dev env.
environments/py-3.12-linux-64.conda.lock.yml Refreshes conda-lock output for Python 3.12 on Linux runtime env.
environments/py-3.12-linux-64-dev.conda.lock.yml Refreshes conda-lock output for Python 3.12 on Linux dev env.
environments/py-3.11-win-64.conda.lock.yml Removes Python 3.11 Windows runtime lockfile.
environments/py-3.11-win-64-dev.conda.lock.yml Removes Python 3.11 Windows dev lockfile.
environments/py-3.11-linux-64.conda.lock.yml Removes Python 3.11 Linux runtime lockfile.
environments/py-3.11-linux-64-dev.conda.lock.yml Removes Python 3.11 Linux dev lockfile.
environments/py-3.10-win-64.conda.lock.yml Removes Python 3.10 Windows runtime lockfile.
environments/py-3.10-win-64-dev.conda.lock.yml Removes Python 3.10 Windows dev lockfile.
environments/py-3.10-linux-64.conda.lock.yml Removes Python 3.10 Linux runtime lockfile.
environments/py-3.10-linux-64-dev.conda.lock.yml Removes Python 3.10 Linux dev lockfile.
environments/env-python-3.13.yml Adds a minimal env input file for conda-lock targeting Python 3.13.
docs/source/conf.py Tweaks how the docs derive/display version when building Sphinx docs.
deps-lock-config.yaml Updates the python versions list to 3.12/3.13 for dependency locking.
.readthedocs.yaml Bumps ReadTheDocs build python to 3.12.
.github/workflows/python_deploy_dev.yml Updates publish workflows to run with Python 3.12.
.github/workflows/python_analysis.yml Updates analysis/pytest matrix to Python 3.12/3.13 and updates codecov reference version.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread recipe.yaml Outdated
Comment thread recipe.yaml Outdated
Comment thread README-dev.rst Outdated
Comment thread docs/source/conf.py
@codecov

codecov Bot commented Jun 15, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 77.40%. Comparing base (df556c5) to head (47174ae).

Files with missing lines Patch % Lines
surface_apps/iso_surfaces/params.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                 @@
##           release/GA_4.8      #47      +/-   ##
==================================================
+ Coverage           76.63%   77.40%   +0.76%     
==================================================
  Files                   5        5              
  Lines                 244      239       -5     
  Branches               29       29              
==================================================
- Hits                  187      185       -2     
+ Misses                 47       44       -3     
  Partials               10       10              
Files with missing lines Coverage Δ
surface_apps/iso_surfaces/params.py 67.64% <66.66%> (+1.89%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@domfournier domfournier requested a review from sebhmg June 15, 2026 17:03
Comment thread .pre-commit-config.yaml Outdated
Comment thread pyproject.toml
Comment thread environments/py-3.12-win-64.conda.lock.yml Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants