Validate vehicle type references across GBFS feeds - #218
Open
mackenziereading19 wants to merge 1 commit into
Open
Validate vehicle type references across GBFS feeds#218mackenziereading19 wants to merge 1 commit into
mackenziereading19 wants to merge 1 commit into
Conversation
👷 Deploy request for gbfs-validator pending review.Visit the deploys page to approve it
|
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a subset of #217.
This adds cross-file validation ensuring
vehicle_type_idvalues infree_bike_status.json/vehicle_status.jsonresolve to IDs defined invehicle_types.json.The check is applied across supported GBFS versions v2.1, v2.2, v2.3, v3.0 and v3.1-RC3.
Existing conditional behaviour requiring
current_range_metersfor motorized vehicle types is preserved.A regression fixture demonstrates the previous false negative in GBFS v3.0, where an undefined
vehicle_type_idpassed validation without errors.Tests
This intentionally does not yet address the other cross-file ID relationships mentioned in #217, such as station, pricing-plan or geofencing references.