Skip to content

fix: handle nested assortment expansion and type narrowing - #32

Merged
MonsterDeveloper merged 1 commit into
mainfrom
fix-nested-expand-assortment-type
Sep 29, 2026
Merged

MonsterDeveloper merged 1 commit into
mainfrom
fix-nested-expand-assortment-type

Conversation

@MonsterDeveloper

Copy link
Copy Markdown
Owner

Summary

  • Omit unsupported nested expand keys from each assortment union member, so Product, Service, and Bundle do not acquire a required product: never field.
  • Let isAssortmentOfType accept assortments by their meta.type discriminator, including demand positions loaded with fields: ["stock"].
  • Add type tests for both regressions.

Checks

  • bun check
  • bun typecheck
  • bun run test

@MonsterDeveloper
MonsterDeveloper merged commit 3fbe28b into main Sep 29, 2026
1 check passed
@MonsterDeveloper
MonsterDeveloper deleted the fix-nested-expand-assortment-type branch September 29, 2026 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant